Bug 227848 – AX: Make WebKit observe spatial audio accessibility settings

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[chris fleizach]

Make WebKit observe spatial audio settings on Mac

<rdar://problem/73590412>

[chris fleizach]

Created attachment 433257 [details]
patch

[EWS]

Committed r279855 (239609@main): <https://commits.webkit.org/239609@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 433257 [details].

[Myles C. Maxfield]

This might have broken the internal build:

Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:1173:27: error: unused function 'increaseContrastPreferenceKey' [-Werror,-Wunused-function]
static const WTF::String& increaseContrastPreferenceKey()

[chris fleizach]

(In reply to Myles C. Maxfield from comment #3)
> This might have broken the internal build:
> 
> Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:1173:27: error: unused
> function 'increaseContrastPreferenceKey' [-Werror,-Wunused-function]
> static const WTF::String& increaseContrastPreferenceKey()

https://bugs.webkit.org/show_bug.cgi?id=227898

[Truitt Savell]

It looks like the changes in https://trac.webkit.org/changeset/279855/webkit

broke TestWebKitAPI.AppleLanguagesTest.UpdateAppleLanguages on Big Sur

history:
https://results.webkit.org/?suite=api-tests&test=TestWebKitAPI.AppleLanguagesTest.UpdateAppleLanguages

Diff:
TestWebKitAPI.AppleLanguagesTest.UpdateAppleLanguages
        
        /Volumes/Data/worker/bigsur-release/build/Tools/TestWebKitAPI/Tests/WebKit/OverrideAppleLanguagesPreference.mm:179
        Value of: didChangeLanguage
          Actual: false
        Expected: true
        
        
        /Volumes/Data/worker/bigsur-release/build/Tools/TestWebKitAPI/Tests/WebKit/OverrideAppleLanguagesPreference.mm:180
        Value of: preferenceObserverPreferenceDidChangeCalled
          Actual: false
        Expected: true
        
        
        /Volumes/Data/worker/bigsur-release/build/Tools/TestWebKitAPI/Tests/WebKit/OverrideAppleLanguagesPreference.mm:181
        Expected equality of these values:
          @"en-US"
            Which is: "en-US"
          preferredLanguage()
            Which is: "en-GB"

I am able to reproduce this with command:
run-api-tests TestWebKitAPI.AppleLanguagesTest.UpdateAppleLanguages

I bisected this and was able to reproduce it on r279855 but no r279854

[chris fleizach]

(In reply to Truitt Savell from comment #5)
> It looks like the changes in https://trac.webkit.org/changeset/279855/webkit
> 
> broke TestWebKitAPI.AppleLanguagesTest.UpdateAppleLanguages on Big Sur
> 
> history:
> https://results.webkit.org/?suite=api-tests&test=TestWebKitAPI.
> AppleLanguagesTest.UpdateAppleLanguages
> 
> Diff:
> TestWebKitAPI.AppleLanguagesTest.UpdateAppleLanguages
>         
>        
> /Volumes/Data/worker/bigsur-release/build/Tools/TestWebKitAPI/Tests/WebKit/
> OverrideAppleLanguagesPreference.mm:179
>         Value of: didChangeLanguage
>           Actual: false
>         Expected: true
>         
>         
>        
> /Volumes/Data/worker/bigsur-release/build/Tools/TestWebKitAPI/Tests/WebKit/
> OverrideAppleLanguagesPreference.mm:180
>         Value of: preferenceObserverPreferenceDidChangeCalled
>           Actual: false
>         Expected: true
>         
>         
>        
> /Volumes/Data/worker/bigsur-release/build/Tools/TestWebKitAPI/Tests/WebKit/
> OverrideAppleLanguagesPreference.mm:181
>         Expected equality of these values:
>           @"en-US"
>             Which is: "en-US"
>           preferredLanguage()
>             Which is: "en-GB"
> 
> I am able to reproduce this with command:
> run-api-tests TestWebKitAPI.AppleLanguagesTest.UpdateAppleLanguages
> 
> I bisected this and was able to reproduce it on r279855 but no r279854

this seems strange. maybe the test is not robust enough. otherwise I don't see anything here that would affect AppleLanguages