Bug 227834 - [GTK] Support dark scrollbars
Summary: [GTK] Support dark scrollbars
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-07-09 04:18 PDT by Alice Mikhaylenko
Modified: 2021-07-09 06:29 PDT (History)
3 users (show)

See Also:

Attachments
Patch (5.51 KB, patch)
2021-07-09 04:22 PDT, Alice Mikhaylenko 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alice Mikhaylenko 2021-07-09 04:18:23 PDT 
Scrollbars in macOS and iOS ports can change color depending on the page, using dark scrollbars on dark pages and light scrollbars on light pages. We should support that too.

See the patch.
Comment 1 Alice Mikhaylenko 2021-07-09 04:22:28 PDT 
Created attachment 433207 [details]
Patch
Comment 2 Alice Mikhaylenko 2021-07-09 04:23:53 PDT 
Test case: https://blog.ergaster.org/

https://webkit.org also triggers a dark scrollbar.
Comment 3 Michael Catanzaro 2021-07-09 05:04:51 PDT 
Comment on attachment 433207 [details]
Patch

LGTM. Maybe Carlos Garcia might want to review this before landing, though?
Comment 4 EWS 2021-07-09 06:29:15 PDT 
Committed r279782 (239549@main): <https://commits.webkit.org/239549@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 433207 [details].