Bug 227817 - [watchOS] Tapping "Done" in Scribble when focusing an editable element should dismiss Quickboard
Summary: [watchOS] Tapping "Done" in Scribble when focusing an editable element should...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-07-08 15:20 PDT by Wenson Hsieh
Modified: 2021-07-08 17:04 PDT (History)
6 users (show)

See Also:

Attachments
Patch (4.31 KB, patch)
2021-07-08 15:34 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Patch (4.31 KB, patch)
2021-07-08 16:01 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2021-07-08 15:20:19 PDT 
rdar://79931134
Comment 1 Wenson Hsieh 2021-07-08 15:34:08 PDT 
Created attachment 433171 [details]
Patch
Comment 2 Wenson Hsieh 2021-07-08 15:57:23 PDT 
Comment on attachment 433171 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433171&action=review

Thanks for the review!

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:6911
> +            [[controller transitionCoordinator] animateAlongsideTransition:nil completion:[dispatchDidDismiss = WTFMove(dispatchDidDismiss)] (id <UIViewControllerTransitionCoordinatorContext>) mutable {

(Devin pointed out that this `mutable` is unnecessary).
Comment 3 Wenson Hsieh 2021-07-08 16:01:59 PDT 
Created attachment 433177 [details]
Patch
Comment 4 EWS 2021-07-08 17:04:56 PDT 
Committed r279764 (239534@main): <https://commits.webkit.org/239534@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 433177 [details].