Bug 227806 - Fix some whitespace handling issues in URL setters
Summary: Fix some whitespace handling issues in URL setters
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-07-08 11:50 PDT by Alex Christensen
Modified: 2021-07-08 16:01 PDT (History)
9 users (show)

See Also:


Attachments
Patch (36.23 KB, patch)
2021-07-08 11:54 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (36.34 KB, patch)
2021-07-08 12:01 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (35.52 KB, patch)
2021-07-08 14:20 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2021-07-08 11:50:47 PDT
Fix some whitespace handling issues in URL setters
Comment 1 Alex Christensen 2021-07-08 11:54:56 PDT
Created attachment 433150 [details]
Patch
Comment 2 Alex Christensen 2021-07-08 12:01:33 PDT
Created attachment 433152 [details]
Patch
Comment 3 Alex Christensen 2021-07-08 14:20:22 PDT
Created attachment 433163 [details]
Patch
Comment 4 Chris Dumez 2021-07-08 15:35:48 PDT
Comment on attachment 433163 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433163&action=review

> Source/WebCore/html/URLDecomposition.cpp:176
> +    for (size_t i = 0; i < string.length(); ++i) {

could use unsigned instead of size_t since that's what string.length() returns.
Comment 5 EWS 2021-07-08 16:00:08 PDT
Committed r279760 (239531@main): <https://commits.webkit.org/239531@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 433163 [details].
Comment 6 Radar WebKit Bug Importer 2021-07-08 16:01:17 PDT
<rdar://problem/80347704>