Bug 22779 – Unit test for the WebKit/Gtk+ API should also check GTK version

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Arthur Webkid]

trunk/WebKit/gtk/tests/main.c

It should check for GTK version >= 2.14 as gtk_test_init is not avaiable for older version of GTK.

Currently, it only checks for GLIB>=2.16

The current result is I can't build Webkit after r39082 with GLIB 2.16 and GTK 2.12.

It fails with the following messages:

./doltlibtool --tag=CC --mode=link gcc  -O2   -o Programs/UnitTests
WebKit/gtk/tests/Programs_UnitTests-main.o libwebkit-1.0.la
-lgtk-x11-2.0 -lgdk-x11-2.0 -latk-1.0 -lgdk_pixbuf-2.0 -lm
-lpangocairo-1.0 -lpango-1.0 -lcairo -lgobject-2.0 -lgmodule-2.0 -ldl
-lglib-2.0   
gcc -O2 -o Programs/.libs/UnitTests
WebKit/gtk/tests/Programs_UnitTests-main.o  ./.libs/libwebkit-1.0.so /usr/lib/libgtk-x11-2.0.so /usr/lib/libgdk-x11-2.0.so /usr/lib/libatk-1.0.so /usr/lib/libgdk_pixbuf-2.0.so -lm /usr/lib/libpangocairo-1.0.so /usr/lib/libpango-1.0.so /usr/lib/libcairo.so /usr/lib/libgobject-2.0.so /usr/lib/libgmodule-2.0.so -ldl /usr/lib/libglib-2.0.so 
WebKit/gtk/tests/Programs_UnitTests-main.o: In function `main':
main.c:(.text+0x37): undefined reference to `gtk_test_init'
collect2: ld returned 1 exit status
make[1]: *** [Programs/UnitTests] Error 1
make[1]: Leaving directory `/home/arthur/src/WebKit-r39090'
make: *** [all] Error 2

Reference: http://trac.webkit.org/changeset/39082

[Adam Bergkvist]

Created attachment 25946 [details]
patch

Here's a quick bug fix since people are having problems building.

[Holger Freyther]

Comment on attachment 25946 [details]
patch

Yes (and I will remove the extra parentheses).

[Holger Freyther]

Landed in r39275.