Bug 227783 – add logging for GraphicsLayerCA::m_uncommittedChanges

• Status: RESOLVED
• Resolution: FIXED
• Component: Compositing

[Cameron McCormack (:heycam)]

.

[Cameron McCormack (:heycam)]

Created attachment 433102 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 433102 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433102&action=review

> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:4136
> +const char* GraphicsLayerCA::layerChangeAsString(LayerChange layerChange)

This is better implemented as TextStream& operator<<(TextStream&, LayerChange)

[Cameron McCormack (:heycam)]

I wanted to but struggled with the enum being private.

[Simon Fraser (smfr)]

Comment on attachment 433102 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433102&action=review

> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:4207
> +    bool first = true;
> +    while (layerChangeFlags) {
> +        if (layerChangeFlags & bit) {
> +            textStream << (first ? " " : ", ") << layerChangeAsString(static_cast<LayerChange>(bit));
> +            first = false;
> +        }
> +        layerChangeFlags &= ~bit;
> +        bit <<= 1;
> +    }
> +    textStream << " }";

Shame that LayerChangeFlags isn' an OptionSet<> because they you wouldn't need this either.

[Cameron McCormack (:heycam)]

Will do that later. https://bugs.webkit.org/show_bug.cgi?id=227787

[EWS]

Committed r279712 (239504@main): <https://commits.webkit.org/239504@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 433102 [details].

[Radar WebKit Bug Importer]

<rdar://problem/80308784>