Bug 227782 - Heap::waitForCollector() needs to set m_mutatorDidRun.
Summary: Heap::waitForCollector() needs to set m_mutatorDidRun.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-07-07 17:36 PDT by Mark Lam
Modified: 2021-07-07 17:55 PDT (History)
6 users (show)

See Also:


Attachments
proposed patch. (1.85 KB, patch)
2021-07-07 17:41 PDT, Mark Lam
sbarati: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2021-07-07 17:36:39 PDT
Heap::waitForCollector() is one of 2 clients of Heap::stopIfNecessarySlow(unsigned oldState).  The other client, Heap::stopIfNecessarySlow() sets m_mutatorDidRun to true after calling Heap::stopIfNecessarySlow(unsigned oldState).  Heap::waitForCollector() needs to do the same.  Constraint solvers rely on this.

rdar://78326474
Comment 1 Mark Lam 2021-07-07 17:41:45 PDT
Created attachment 433099 [details]
proposed patch.
Comment 2 Mark Lam 2021-07-07 17:55:16 PDT
Thanks for the review.  Landed in r279689: <http://trac.webkit.org/r279689>.