Bug 22776 – Add ScriptController::updateSecurityOrigin

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Adam Barth]

We should call a method on ScriptController when we update a document's securityOrigin.  V8 uses this method to update the security context it uses in its fast-path security check.  Currently, the JavaScriptCore bindings don't have use for this method, but it might in the future.

Patch forthcoming.

[Adam Barth]

Created attachment 25912 [details]
patch

[Adam Barth]

For those keeping score at home, this method corresponds to / replaces SecriptController::setDomain in http://src.chromium.org/viewvc/chrome/trunk/src/webkit/port/bindings/v8/ScriptController.h?view=markup

[Sam Weinig]

Comment on attachment 25912 [details]
patch

>          securityOrigin()->setDomainFromDOM(newDomain);
> +        if (m_frame)
> +             m_frame->script()->updateSecurityOrigin();

The indentation looks odd here.

>      securityOrigin()->setDomainFromDOM(newDomain);
> +    if (m_frame)
> +         m_frame->script()->updateSecurityOrigin();

And here.

r=me

[Adam Barth]

Fixed in r39163.  Thanks for the quick review!

[Darin Fisher (:fishd, Google)]

Comment on attachment 25912 [details]
patch

>diff --git a/WebCore/dom/Document.cpp b/WebCore/dom/Document.cpp
...
>+        if (m_frame)
>+             m_frame->script()->updateSecurityOrigin();
>         return;
...
>+    if (m_frame)
>+         m_frame->script()->updateSecurityOrigin();
> }

FYI: indentation looks to be off by one space.

[Adam Barth]

> FYI: indentation looks to be off by one space.

Thanks.  I think I fixed this before landing.