Bug 227751 - [Legacy Line Layout] Do not integral round the root inlinebox's top position
Summary: [Legacy Line Layout] Do not integral round the root inlinebox's top position
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-07-07 10:27 PDT by zalan
Modified: 2021-09-10 21:24 PDT (History)
16 users (show)

See Also:

Attachments
Patch (1.74 MB, patch)
2021-09-09 14:27 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (1.74 MB, patch)
2021-09-09 20:59 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (1.74 MB, patch)
2021-09-10 09:47 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (1.75 MB, patch)
2021-09-10 15:07 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2021-07-07 10:27:33 PDT 
snapping should rather happen during painting
Comment 1 Radar WebKit Bug Importer 2021-07-14 10:28:27 PDT 
<rdar://problem/80584346>
Comment 2 zalan 2021-09-09 14:27:35 PDT 
Created attachment 437785 [details]
Patch
Comment 3 zalan 2021-09-09 20:59:43 PDT 
Created attachment 437833 [details]
Patch
Comment 4 zalan 2021-09-10 09:47:29 PDT 
Created attachment 437883 [details]
Patch
Comment 5 zalan 2021-09-10 15:07:55 PDT 
Created attachment 437912 [details]
Patch
Comment 6 zalan 2021-09-10 16:00:54 PDT 
We push the coordinate values through a bunch of implicit and explicit integral conversions as we dump them (see webkit.org/b/230174). It's misleading as renderers may be at a slightly different position (e.g. vertical -1px values).
Comment 7 EWS 2021-09-10 21:24:30 PDT 
Committed r282306 (241578@main): <https://commits.webkit.org/241578@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 437912 [details].