Bug 227747 - XPC services should release their os transaction when given a SIGTERM signal
Summary: XPC services should release their os transaction when given a SIGTERM signal
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-07-07 09:17 PDT by Alex Christensen
Modified: 2021-07-13 13:56 PDT (History)
2 users (show)

See Also:

Attachments
Patch (2.99 KB, patch)
2021-07-07 09:21 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (1.87 KB, patch)
2021-07-07 09:51 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2021-07-07 09:17:31 PDT 
XPC services should release their os transaction when given a SIGTERM signal
Comment 1 Alex Christensen 2021-07-07 09:21:38 PDT 
Created attachment 433035 [details]
Patch
Comment 2 Alex Christensen 2021-07-07 09:21:41 PDT 
<rdar://problem/72430454>
Comment 3 Geoffrey Garen 2021-07-07 09:41:54 PDT 
Comment on attachment 433035 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433035&action=review

r=me

> Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.h:105
> +    signal(SIGTERM, releaseOSTransaction);

FWIW, I like using no-capture lambdas in cases like this.
Comment 4 Alex Christensen 2021-07-07 09:51:27 PDT 
Created attachment 433038 [details]
Patch
Comment 5 EWS 2021-07-07 10:32:26 PDT 
Committed r279647 (239460@main): <https://commits.webkit.org/239460@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 433038 [details].
Comment 6 Alex Christensen 2021-07-13 13:56:55 PDT 
Reverted in r279890