Bug 227735 - Add WKHoverPlatter and some knobs to tweak its appearance
Summary: Add WKHoverPlatter and some knobs to tweak its appearance
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-07-06 21:45 PDT by Tim Horton
Modified: 2021-07-07 23:46 PDT (History)
4 users (show)

See Also:

Attachments
Patch (49.92 KB, patch)
2021-07-06 21:46 PDT, Tim Horton 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (50.00 KB, patch)
2021-07-06 22:05 PDT, Tim Horton 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (51.30 KB, patch)
2021-07-06 22:30 PDT, Tim Horton 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (57.89 KB, patch)
2021-07-06 23:01 PDT, Tim Horton 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (57.94 KB, patch)
2021-07-06 23:59 PDT, Tim Horton 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (57.94 KB, patch)
2021-07-07 00:23 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (57.85 KB, patch)
2021-07-07 17:24 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (57.86 KB, patch)
2021-07-07 21:49 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Show Obsolete (7) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2021-07-06 21:45:20 PDT 
Add WKHoverPlatter and some knobs to tweak its appearance
Comment 1 Tim Horton 2021-07-06 21:46:37 PDT 
Created attachment 433008 [details]
Patch
Comment 2 Tim Horton 2021-07-06 21:46:39 PDT 
<rdar://problem/79198262>
Comment 3 Tim Horton 2021-07-06 22:05:00 PDT 
Created attachment 433009 [details]
Patch
Comment 4 Tim Horton 2021-07-06 22:30:10 PDT 
Created attachment 433012 [details]
Patch
Comment 5 Tim Horton 2021-07-06 23:01:15 PDT 
Created attachment 433013 [details]
Patch
Comment 6 Tim Horton 2021-07-06 23:59:01 PDT 
Created attachment 433018 [details]
Patch
Comment 7 Tim Horton 2021-07-07 00:23:13 PDT 
Created attachment 433019 [details]
Patch
Comment 8 Sam Weinig 2021-07-07 13:36:48 PDT 
Comment on attachment 433019 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433019&action=review

> Source/WebKit/UIProcess/ios/WKHoverPlatter.mm:40
> +        RetainPtr<CASpringAnimation> spring = adoptNS([[CASpringAnimation alloc] init]);

auto?

> Source/WebKit/UIProcess/ios/WKHoverPlatter.mm:49
> +    RetainPtr<CABasicAnimation> ease = adoptNS([[CABasicAnimation alloc] init]);

auto?

> Source/WebKit/UIProcess/ios/WKHoverPlatter.mm:58
> +    RetainPtr<CABasicAnimation> animation = createBaseAnimation();

auto?

> Source/WebKit/UIProcess/ios/WKHoverPlatter.mm:189
> +    RetainPtr<CGPathRef> inflatedPath = WebCore::PathUtilities::pathWithShrinkWrappedRects(inflatedIndicatedRects, parameters.platterCornerRadius).platformPath();

auto?
Comment 9 Tim Horton 2021-07-07 17:24:06 PDT 
Created attachment 433096 [details]
Patch
Comment 10 Tim Horton 2021-07-07 21:49:30 PDT 
Created attachment 433117 [details]
Patch
Comment 11 EWS 2021-07-07 23:46:57 PDT 
Committed r279711 (239503@main): <https://commits.webkit.org/239503@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 433117 [details].