RESOLVED FIXED 22773
pauseAnimationAtTimeOnElementWithId() does not work with animations using multiple keyframes 
https://bugs.webkit.org/show_bug.cgi?id=22773
Summary pauseAnimationAtTimeOnElementWithId() does not work with animations using mul...
Pierre-Olivier Latour
Reported 2008-12-09 17:42:43 PST
pauseAnimationAtTimeOnElementWithId() does not work with animations using multiple keyframes
Attachments
Patch (44.80 KB, patch)
2008-12-09 18:32 PST, Pierre-Olivier Latour 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pierre-Olivier Latour
Comment 1 2008-12-09 18:32:37 PST
Created attachment 25909 [details] Patch The issue is that KeyframeAnimation::animate() does not compute the ellapsed time exactly the same way that AnimationBase::progress() does.
Simon Fraser (smfr)
Comment 2 2008-12-09 21:18:02 PST
I think the testcase should be a text test (dumpAsText()), and should put "PASS" or "FAIL" in the document rather than throwing.
Darin Adler
Comment 3 2008-12-10 09:41:19 PST
Comment on attachment 25909 [details] Patch Could we change this so that KeyframeAnimation::animate() shared more code with AnimationBase::progress() so they can't get out of sync? r=me as-is
Pierre-Olivier Latour
Comment 4 2008-12-10 09:42:21 PST
> I think the testcase should be a text test (dumpAsText()), and should put > "PASS" or "FAIL" in the document rather than throwing. If this test fails, the render tree output will be different. Throwing just happens if the animation does not exist in the first place, which is not what this test looks at. It's also consistent with the other DRT animation API tests added so far.
Pierre-Olivier Latour
Comment 5 2008-12-10 09:42:57 PST
(In reply to comment #3) > (From update of attachment 25909 [details] [review]) > Could we change this so that KeyframeAnimation::animate() shared more code with > AnimationBase::progress() so they can't get out of sync? Absolutely, we have a radar on this, Chris will look at it.
Pierre-Olivier Latour
Comment 6 2008-12-10 10:01:08 PST
Sending LayoutTests/ChangeLog Adding LayoutTests/animations/animation-drt-api-multiple-keyframes.html Adding LayoutTests/platform/mac/animations/animation-drt-api-multiple-keyframes-expected.checksum Adding (bin) LayoutTests/platform/mac/animations/animation-drt-api-multiple-keyframes-expected.png Adding LayoutTests/platform/mac/animations/animation-drt-api-multiple-keyframes-expected.txt Sending LayoutTests/platform/win/Skipped Sending WebCore/ChangeLog Sending WebCore/page/animation/KeyframeAnimation.cpp Transmitting file data ........ Committed revision 39176.
Note You need to log in before you can comment on or make changes to this bug.