Bug 227725 - SubtleCrypto should only be exposed to secure contexts
Summary: SubtleCrypto should only be exposed to secure contexts
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
: 166959 (view as bug list)
Depends on: 227737
Blocks:
  Show dependency tree / graph
 
Reported: 2021-07-06 15:09 PDT by Chris Dumez
Modified: 2021-08-17 10:54 PDT (History)
11 users (show)

See Also:

Attachments
Patch (5.03 KB, patch)
2021-07-06 15:39 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2021-07-06 15:09:33 PDT 
SubtleCrypto should only be exposed to secure contexts:
- https://www.w3.org/TR/WebCryptoAPI/#dfn-Crypto

Gecko and Blink match the specification.

This is causing WebKit to fail the WebCryptoAPI/historical.any.html WPT test.
Comment 1 Chris Dumez 2021-07-06 15:39:26 PDT 
Created attachment 432984 [details]
Patch
Comment 2 EWS 2021-07-06 16:55:01 PDT 
Committed r279628 (239446@main): <https://commits.webkit.org/239446@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 432984 [details].
Comment 3 Radar WebKit Bug Importer 2021-07-06 16:56:18 PDT 
<rdar://problem/80238331>
Comment 4 Alexey Proskuryakov 2021-07-06 19:39:59 PDT 
This is a case of making things strictly worse because of someone else’s agenda.
Comment 5 WebKit Commit Bot 2021-07-06 23:03:59 PDT 
Re-opened since this is blocked by bug 227737
Comment 6 Chris Dumez 2021-07-07 08:37:36 PDT 
Committed r279642 (239455@main): <https://commits.webkit.org/239455@main>
Comment 7 Sam Sneddon [:gsnedders] 2021-08-17 10:54:26 PDT 
*** Bug 166959 has been marked as a duplicate of this bug. ***