Bug 227722 - Fix type error in testb3
Summary: Fix type error in testb3
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yijia Huang
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-07-06 14:30 PDT by Yijia Huang
Modified: 2021-07-06 15:50 PDT (History)
8 users (show)

See Also:

Attachments
Patch (2.18 KB, patch)
2021-07-06 14:50 PDT, Yijia Huang 		no flags Details | Formatted Diff | Diff
Patch (4.15 KB, patch)
2021-07-06 15:06 PDT, Yijia Huang 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yijia Huang 2021-07-06 14:30:47 PDT 
...
Comment 1 Yijia Huang 2021-07-06 14:50:29 PDT 
Created attachment 432976 [details]
Patch
Comment 2 Mark Lam 2021-07-06 14:54:48 PDT 
Comment on attachment 432976 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=432976&action=review

> Source/JavaScriptCore/b3/testb3_3.cpp:93
>          Value* lsbValue = root->appendNew<Const32Value>(proc, Origin(), lsb);
> -        Value* amountValue = root->appendNew<Const64Value>(proc, Origin(), amount);
> +        Value* amountValue = root->appendNew<Const32Value>(proc, Origin(), amount);

Why pass lab and amount in as int64_t then?  Ditto for lsbs and widths vectors, why Vector<int64_t>?
Comment 3 Mark Lam 2021-07-06 14:55:50 PDT 
(In reply to Mark Lam from comment #2)
> Comment on attachment 432976 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=432976&action=review
> 
> > Source/JavaScriptCore/b3/testb3_3.cpp:93
> >          Value* lsbValue = root->appendNew<Const32Value>(proc, Origin(), lsb);
> > -        Value* amountValue = root->appendNew<Const64Value>(proc, Origin(), amount);
> > +        Value* amountValue = root->appendNew<Const32Value>(proc, Origin(), amount);
> 
> Why pass lab and amount in as int64_t then?  Ditto for lsbs and widths
> vectors, why Vector<int64_t>?

Can you fix these as well?
Comment 4 Yijia Huang 2021-07-06 15:06:28 PDT 
Created attachment 432980 [details]
Patch
Comment 5 EWS 2021-07-06 15:49:40 PDT 
Committed r279627 (239445@main): <https://commits.webkit.org/239445@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 432980 [details].
Comment 6 Radar WebKit Bug Importer 2021-07-06 15:50:21 PDT 
<rdar://problem/80235431>