RESOLVED FIXED 227721
[Cairo] Merge PlatformContextCairo into GraphicsContextCairo 
https://bugs.webkit.org/show_bug.cgi?id=227721
Summary [Cairo] Merge PlatformContextCairo into GraphicsContextCairo
Fujii Hironori
Reported 2021-07-06 14:30:03 PDT
[Cairo] Merge PlatformContextCairo into GraphicsContextCairo PlatformContextCairo was originally introduced to separate Cairo specific code from the platform-independent GraphicsContext. However, GraphicsContext is a virtual class nowadays. And, GraphicsContextCairo is a Cairo specifix concrete class.
Attachments
WIP patch (547 bytes, patch)
2021-07-06 14:31 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
WIP patch (75.07 KB, patch)
2021-07-06 14:31 PDT, Fujii Hironori 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
WIP patch (75.21 KB, patch)
2021-07-06 14:44 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Patch (85.56 KB, patch)
2021-07-06 17:30 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2021-07-06 14:31:13 PDT
Created attachment 432972 [details] WIP patch
Fujii Hironori
Comment 2 2021-07-06 14:31:51 PDT
Created attachment 432973 [details] WIP patch
Fujii Hironori
Comment 3 2021-07-06 14:44:53 PDT
Created attachment 432975 [details] WIP patch
Fujii Hironori
Comment 4 2021-07-06 17:20:04 PDT
EWS style checker failed. > ERROR: Source/WebCore/platform/graphics/cairo/GraphicsContextGLCairo.cpp:34: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] check-webkit-style considers "GraphicsContext.h" is the primary header for GraphicsContextGLCairo.cpp. I think GraphicsContextGLCairo.cpp should be renamed to GraphicsContextGLOpenGLCairo.cpp to make "GraphicsContextGLOpenGL.h" the primary header.
Fujii Hironori
Comment 5 2021-07-06 17:30:57 PDT
Created attachment 432992 [details] Patch
Don Olmstead
Comment 6 2021-07-07 11:09:24 PDT
Comment on attachment 432992 [details] Patch r=me
Fujii Hironori
Comment 7 2021-07-07 12:44:06 PDT
Comment on attachment 432992 [details] Patch Clearing flags on attachment: 432992 Committed r279658 (239471@main): <https://commits.webkit.org/239471@main>
Fujii Hironori
Comment 8 2021-07-07 12:44:10 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2021-07-07 12:45:19 PDT
<rdar://problem/80284526>
Fujii Hironori
Comment 10 2021-07-08 21:43:42 PDT
This change causes new test crashes. Filed: Bug 227827 – [WinCairo] drag tests are crashing after r279658
Tim Horton
Comment 11 2021-07-12 12:18:38 PDT
Nice, thank you for doing some follow-through on the refactor! This is great :)
Note You need to log in before you can comment on or make changes to this bug.