It would seem that that in webkit builds using the gstreamer backend, looped videos are not seamless. File to reproduce: https://ftp.octaforge.org/q66/random/red.mp4 HTML source for test: <video src="red.mp4" autoplay loop /> This "flicker" happens after the player stops and before it starts again. It should be reproducible with any video, but the above is guaranteed to reproduce the problem.
Created attachment 433790 [details] Patch
Comment on attachment 433790 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=433790&action=review > Source/WebCore/ChangeLog:10 > + non-flushing seeks to seek back to the beginning of the media. This ensure a seamless > + behavior has the pipeline state doesn't change and sinks don't flush. This can be done only This ensure...don't flush does not "parse". > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:471 > + Extra line
Comment on attachment 433790 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=433790&action=review >> Source/WebCore/ChangeLog:10 >> + behavior has the pipeline state doesn't change and sinks don't flush. This can be done only > > This ensure...don't flush does not "parse". s/has/as :) Thanks for the review.
Hum this breaks pages with videos containing webm/alpha. Can't land as-is.
Pull request: https://github.com/WebKit/WebKit/pull/4989
Committed 263860@main (bc8bd3bac663): <https://commits.webkit.org/263860@main> Reviewed commits have been landed. Closing PR #4989 and removing active labels.