Bug 227662 - [WebIDL] Properly validate and merge descriptors in [Replaceable] setter
Summary: [WebIDL] Properly validate and merge descriptors in [Replaceable] setter
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Trivial
Assignee: Alexey Shvayka
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-07-03 09:44 PDT by Alexey Shvayka
Modified: 2021-07-23 18:56 PDT (History)
9 users (show)

See Also:


Attachments
Patch (22.71 KB, patch)
2021-07-03 10:05 PDT, Alexey Shvayka
no flags Details | Formatted Diff | Diff
Patch (22.78 KB, patch)
2021-07-05 06:48 PDT, Alexey Shvayka
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Shvayka 2021-07-03 09:44:03 PDT
[WebIDL] Properly validate and merge descriptors in [Replaceable] setter
Comment 1 Alexey Shvayka 2021-07-03 10:05:02 PDT
Created attachment 432852 [details]
Patch
Comment 2 Sam Weinig 2021-07-04 10:37:18 PDT
Comment on attachment 432852 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=432852&action=review

> Source/JavaScriptCore/runtime/JSObject.h:808
> +    JS_EXPORT_PRIVATE bool createDataProperty(JSGlobalObject*, PropertyName, JSValue, bool shouldThrow);

JS_EXPORT_PRIVATE is not needed when the function is inlined (as this one is).
Comment 3 Alexey Shvayka 2021-07-05 06:48:29 PDT
Created attachment 432881 [details]
Patch

Remove JS_EXPORT_PRIVATE to fix weak external symbol build error.
Comment 4 Radar WebKit Bug Importer 2021-07-10 09:45:15 PDT
<rdar://problem/80419243>
Comment 5 Alexey Shvayka 2021-07-23 18:19:28 PDT
Comment on attachment 432881 [details]
Patch

Thank you for review and helping out with the linker error, Sam!
Comment 6 EWS 2021-07-23 18:56:41 PDT
Committed r280280 (239938@main): <https://commits.webkit.org/239938@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 432881 [details].