Bug 227655 - [OpenSSL] Implement CryptoAlgorithmEC*
Summary: [OpenSSL] Implement CryptoAlgorithmEC*
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yoshiaki Jitsukawa
URL:
Keywords: InRadar
Depends on:
Blocks: 206439
  Show dependency tree / graph
 
Reported: 2021-07-03 00:53 PDT by Yoshiaki Jitsukawa
Modified: 2021-07-07 15:53 PDT (History)
5 users (show)

See Also:

Attachments
Patch (58.51 KB, patch)
2021-07-06 05:49 PDT, Yoshiaki Jitsukawa 		no flags Details | Formatted Diff | Diff
Patch (58.53 KB, patch)
2021-07-06 17:19 PDT, Yoshiaki Jitsukawa 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yoshiaki Jitsukawa 2021-07-03 00:53:58 PDT 
Implement elliptic curve things.
Comment 1 Yoshiaki Jitsukawa 2021-07-06 05:49:16 PDT 
Created attachment 432919 [details]
Patch
Comment 2 Stephan Szabo 2021-07-06 08:10:03 PDT 
Comment on attachment 432919 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=432919&action=review

> Source/WebCore/crypto/openssl/CryptoKeyECOpenSSL.cpp:272
> +        return false;

This seems like it should be a return nullptr;

Appears to cause a failure for me on playstation complaining about no viable conversion from returned value of type 'bool' to function return type 'RefPtr<WebCore::CryptoKeyEC>.
Comment 3 Yoshiaki Jitsukawa 2021-07-06 17:19:27 PDT 
Created attachment 432990 [details]
Patch
Comment 4 Yoshiaki Jitsukawa 2021-07-06 17:22:39 PDT 
> This seems like it should be a return nullptr;

Thanks, I fixed it with the new patch along with warning fixes of ptrdiff vs size_t comparison in CryptoKeyEC::platformImportSpki/Pkcs8().
Comment 5 EWS 2021-07-07 15:52:43 PDT 
Committed r279682 (239487@main): <https://commits.webkit.org/239487@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 432990 [details].
Comment 6 Radar WebKit Bug Importer 2021-07-07 15:53:18 PDT 
<rdar://problem/80293316>