Bug 227632 - Regression(r278786) LocalStorageDatabase's transaction may be remain active when process gets suspended
Summary: Regression(r278786) LocalStorageDatabase's transaction may be remain active w...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 226938
  Show dependency tree / graph
 
Reported: 2021-07-02 11:36 PDT by Chris Dumez
Modified: 2021-07-02 13:24 PDT (History)
4 users (show)

See Also:

Attachments
Patch (3.85 KB, patch)
2021-07-02 11:44 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2021-07-02 11:36:26 PDT 
LocalStorageDatabase's transaction may be remain active when process gets suspended. LocalStorageDatabase commits its transaction after 500ms. However, when PrepareToSuspend gets called, we suspend/hang the storage thread and the task to commit the transaction cannot get committed.
Comment 1 Chris Dumez 2021-07-02 11:44:37 PDT 
Created attachment 432808 [details]
Patch
Comment 2 Geoffrey Garen 2021-07-02 13:10:17 PDT 
Comment on attachment 432808 [details]
Patch

r=me
Comment 3 EWS 2021-07-02 13:23:06 PDT 
Committed r279512 (239364@main): <https://commits.webkit.org/239364@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 432808 [details].
Comment 4 Radar WebKit Bug Importer 2021-07-02 13:24:16 PDT 
<rdar://problem/80099966>