Bug 227600 - [run-webkit-tests] Set software_variant from runtime
Summary: [run-webkit-tests] Set software_variant from runtime
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-07-01 16:20 PDT by Jonathan Bedard
Modified: 2021-07-01 21:05 PDT (History)
4 users (show)

See Also:

Attachments
Patch (6.26 KB, patch)
2021-07-01 16:27 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2021-07-01 16:20:57 PDT 
We currently try to infer the software_variant from the runtime. This is not really correct, the software_variant should be derived from the runtime. This is particularly relevant for iPhone and iPad where two device_families share a software_variant.
Comment 1 Jonathan Bedard 2021-07-01 16:23:32 PDT 
<rdar://problem/80052263>
Comment 2 Jonathan Bedard 2021-07-01 16:27:22 PDT 
Created attachment 432743 [details]
Patch
Comment 3 EWS 2021-07-01 21:05:49 PDT 
Committed r279496 (239348@main): <https://commits.webkit.org/239348@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 432743 [details].