loadSimulatedRequest: should do same delegate callbacks as loadHTMLString and loadData
Created attachment 432731 [details]
Comment on attachment 432731 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=432731&action=review
> + EXPECT_EQ(vector.size(), 4u);
ASSERT_EQ() as we'll crash otherwise.
Created attachment 432737 [details]
Committed r279494 (239346@main): <https://commits.webkit.org/239346@main>
All reviewed patches have been landed. Closing bug and clearing flags on attachment 432737 [details].
(In reply to EWS from comment #5)
> Committed r279494 (239346@main): <https://commits.webkit.org/239346@main>
This broke TestWebKitAPI.WKWebView.LoadSimulatedRequestUpdatesBackForwardList
Also indicated by EWS (https://ews-build.webkit.org/#/builders/9/builds/50270, https://ews-build.webkit.org/#/builders/3/builds/51248)
Re-opened since this is blocked by bug 227628
Created attachment 432841 [details]
Comment on attachment 432841 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=432841&action=review
I also wanted to add this:
Before this change we set SubstituteData.failingURL, which in FrameLoader::PolicyChecker::checkNavigationPolicy makes it behave more like _loadAlternateHTMLString which doesn't call decidePolicyForNavigationAction and does add a back/forward entry. We want it to behave more like loadHTMLString, which does call decidePolicyForNavigationAction and doesn't add a back/forward entry. Except we do want it to add a back/forward entry. This patch is to accomplish that.