227599 – loadSimulatedRequest: should do same delegate callbacks as loadHTMLString and loadData

Bug 227599 - loadSimulatedRequest: should do same delegate callbacks as loadHTMLString and loadData

Summary: loadSimulatedRequest: should do same delegate callbacks as loadHTMLString and...

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	New Bugs (show other bugs)
Version:	WebKit Nightly Build
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Alex Christensen

URL:
Keywords:	InRadar

Depends on:	227628
Blocks:
	Show dependency tree / graph

Reported:	2021-07-01 15:22 PDT by Alex Christensen
Modified:	2021-07-06 10:34 PDT (History)
CC List:	9 users (show)

See Also:

Attachments
Patch (5.61 KB, patch) 2021-07-01 15:23 PDT, Alex Christensen	no flags	Details \| Formatted Diff \| Diff
Patch (5.60 KB, patch) 2021-07-01 15:45 PDT, Alex Christensen	no flags	Details \| Formatted Diff \| Diff
Patch (33.43 KB, patch) 2021-07-02 21:45 PDT, Alex Christensen	no flags	Details \| Formatted Diff \| Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Alex Christensen 2021-07-01 15:22:55 PDT

loadSimulatedRequest: should do same delegate callbacks as loadHTMLString and loadData

Comment 1 Alex Christensen 2021-07-01 15:23:27 PDT

Created attachment 432731 [details]
Patch

Comment 2 Chris Dumez 2021-07-01 15:26:48 PDT

Comment on attachment 432731 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=432731&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewLoadAPIs.mm:97
> +        EXPECT_EQ(vector.size(), 4u);

ASSERT_EQ() as we'll crash otherwise.

Comment 3 Alex Christensen 2021-07-01 15:45:44 PDT

Created attachment 432737 [details]
Patch

Comment 4 Wenson Hsieh 2021-07-01 16:16:30 PDT

rdar://78578639

Comment 5 EWS 2021-07-01 18:45:38 PDT

Committed r279494 (239346@main): <https://commits.webkit.org/239346@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 432737 [details].

Comment 6 Aakash Jain 2021-07-02 08:01:31 PDT

(In reply to EWS from comment #5)
> Committed r279494 (239346@main): <https://commits.webkit.org/239346@main>
This broke TestWebKitAPI.WKWebView.LoadSimulatedRequestUpdatesBackForwardList
Also indicated by EWS (https://ews-build.webkit.org/#/builders/9/builds/50270, https://ews-build.webkit.org/#/builders/3/builds/51248) 

History: https://results.webkit.org/?suite=api-tests&test=TestWebKitAPI.WKWebView.LoadSimulatedRequestUpdatesBackForwardList

Comment 7 WebKit Commit Bot 2021-07-02 08:03:07 PDT

Re-opened since this is blocked by bug 227628

Comment 8 Alex Christensen 2021-07-02 21:45:05 PDT

Created attachment 432841 [details]
Patch

Comment 9 Alex Christensen 2021-07-02 22:26:30 PDT

Comment on attachment 432841 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=432841&action=review

> Source/WebKit/ChangeLog:9
> +

I also wanted to add this:
Before this change we set SubstituteData.failingURL, which in FrameLoader::PolicyChecker::checkNavigationPolicy makes it behave more like _loadAlternateHTMLString which doesn't call decidePolicyForNavigationAction and does add a back/forward entry.  We want it to behave more like loadHTMLString, which does call decidePolicyForNavigationAction and doesn't add a back/forward entry.  Except we do want it to add a back/forward entry.  This patch is to accomplish that.

Comment 10 Alex Christensen 2021-07-06 10:34:15 PDT

r279595