Bug 227597 – Web Inspector: [Regression: r279271] Sources: Breakpoints section in navigation sidebar disappears when Web Inspector becomes taller than 650px

• Status: RESOLVED
• Resolution: CONFIGURATION CHANGED
• Component: Web Inspector

[Patrick Angle]

Created attachment 432724 [details]
Video of Issue

Changes to flex behavior mean that the breakpoints section of the navigation sidebar no longer appears when Web Inspector is more than 650px tall.

[Radar WebKit Bug Importer]

<rdar://problem/80045542>

[Patrick Angle]

Created attachment 432734 [details]
Patch v1.0

[Patrick Angle]

Created attachment 432735 [details]
Video of Patch v1.0

[Devin Rousso]

Comment on attachment 432734 [details]
Patch v1.0

View in context: https://bugs.webkit.org/attachment.cgi?id=432734&action=review

r=me, nice catch :)

I wonder how many other bugs there are like this :(

> Source/WebInspectorUI/UserInterface/Views/SourcesNavigationSidebarPanel.css:-134
> -        height: 100%;

I think we may want a `flex-basis: 100%` or something here.  The idea behind this and the code below it is that we give priority to things higher in the sidebar than lower, so if the developer is decreasing the height of the Web Inspector window, we don't want the Call Stack section to start collapsing until after the Breakpoints section has started collapsing.

[Patrick Angle]

Created attachment 432741 [details]
Patch v1.1 - Add flex-basis

[Patrick Angle]

Comment on attachment 432741 [details]
Patch v1.1 - Add flex-basis

This actually doesn't work, due to another flex-related bug.

[Patrick Angle]

Created attachment 432744 [details]
Patch v1.2 - Remove flex-basis

[EWS]

Committed r279493 (239345@main): <https://commits.webkit.org/239345@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 432744 [details].

[WebKit Commit Bot]

Re-opened since this is blocked by bug 227878