Bug 227597 - Web Inspector: [Regression: r279271] Sources: Breakpoints section in navigation sidebar disappears when Web Inspector becomes taller than 650px
Summary: Web Inspector: [Regression: r279271] Sources: Breakpoints section in navigati...
Status: RESOLVED CONFIGURATION CHANGED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Patrick Angle
URL:
Keywords: InRadar
Depends on: 225590 227878
Blocks:
  Show dependency treegraph
 
Reported: 2021-07-01 14:14 PDT by Patrick Angle
Modified: 2022-02-12 13:39 PST (History)
6 users (show)

See Also:


Attachments
Video of Issue (14.90 MB, video/quicktime)
2021-07-01 14:14 PDT, Patrick Angle
no flags Details
Patch v1.0 (2.25 KB, patch)
2021-07-01 15:32 PDT, Patrick Angle
no flags Details | Formatted Diff | Diff
Video of Patch v1.0 (40.88 MB, video/quicktime)
2021-07-01 15:34 PDT, Patrick Angle
no flags Details
Patch v1.1 - Add flex-basis (2.29 KB, patch)
2021-07-01 16:10 PDT, Patrick Angle
no flags Details | Formatted Diff | Diff
Patch v1.2 - Remove flex-basis (2.24 KB, patch)
2021-07-01 16:37 PDT, Patrick Angle
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Angle 2021-07-01 14:14:55 PDT
Created attachment 432724 [details]
Video of Issue

Changes to flex behavior mean that the breakpoints section of the navigation sidebar no longer appears when Web Inspector is more than 650px tall.
Comment 1 Radar WebKit Bug Importer 2021-07-01 14:15:31 PDT
<rdar://problem/80045542>
Comment 2 Patrick Angle 2021-07-01 15:32:37 PDT
Created attachment 432734 [details]
Patch v1.0
Comment 3 Patrick Angle 2021-07-01 15:34:47 PDT
Created attachment 432735 [details]
Video of Patch v1.0
Comment 4 Devin Rousso 2021-07-01 16:01:45 PDT
Comment on attachment 432734 [details]
Patch v1.0

View in context: https://bugs.webkit.org/attachment.cgi?id=432734&action=review

r=me, nice catch :)

I wonder how many other bugs there are like this :(

> Source/WebInspectorUI/UserInterface/Views/SourcesNavigationSidebarPanel.css:-134
> -        height: 100%;

I think we may want a `flex-basis: 100%` or something here.  The idea behind this and the code below it is that we give priority to things higher in the sidebar than lower, so if the developer is decreasing the height of the Web Inspector window, we don't want the Call Stack section to start collapsing until after the Breakpoints section has started collapsing.
Comment 5 Patrick Angle 2021-07-01 16:10:11 PDT
Created attachment 432741 [details]
Patch v1.1 - Add flex-basis
Comment 6 Patrick Angle 2021-07-01 16:24:34 PDT
Comment on attachment 432741 [details]
Patch v1.1 - Add flex-basis

This actually doesn't work, due to another flex-related bug.
Comment 7 Patrick Angle 2021-07-01 16:37:12 PDT
Created attachment 432744 [details]
Patch v1.2 - Remove flex-basis
Comment 8 EWS 2021-07-01 18:36:11 PDT
Committed r279493 (239345@main): <https://commits.webkit.org/239345@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 432744 [details].
Comment 9 WebKit Commit Bot 2021-07-12 10:46:30 PDT
Re-opened since this is blocked by bug 227878