Bug 227594 - [Legacy line layout] Inline content on subpixel position makes the table cell scroll
Summary: [Legacy line layout] Inline content on subpixel position makes the table cell...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-07-01 13:34 PDT by zalan
Modified: 2021-07-07 14:35 PDT (History)
15 users (show)

See Also:

Attachments
Patch (7.63 KB, patch)
2021-07-01 13:42 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (7.62 KB, patch)
2021-07-01 13:46 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (9.21 KB, patch)
2021-07-01 18:20 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (9.98 KB, patch)
2021-07-02 12:43 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (5.94 KB, patch)
2021-07-06 16:38 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (6.30 KB, patch)
2021-07-06 16:55 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (20.46 KB, patch)
2021-07-06 18:57 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (20.54 KB, patch)
2021-07-06 21:08 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (41.77 KB, patch)
2021-07-07 06:41 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (46.11 KB, patch)
2021-07-07 11:19 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (9) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2021-07-01 13:34:06 PDT 
<rdar://74884402>
Comment 1 zalan 2021-07-01 13:42:17 PDT 
Created attachment 432721 [details]
Patch
Comment 2 zalan 2021-07-01 13:46:02 PDT 
Created attachment 432722 [details]
Patch
Comment 3 zalan 2021-07-01 18:20:00 PDT 
Created attachment 432761 [details]
Patch
Comment 4 zalan 2021-07-02 12:43:35 PDT 
Created attachment 432812 [details]
Patch
Comment 5 zalan 2021-07-06 16:38:58 PDT 
Created attachment 432987 [details]
Patch
Comment 6 zalan 2021-07-06 16:55:12 PDT 
Created attachment 432989 [details]
Patch
Comment 7 zalan 2021-07-06 18:57:18 PDT 
Created attachment 432997 [details]
Patch
Comment 8 zalan 2021-07-06 21:08:40 PDT 
Created attachment 433006 [details]
Patch
Comment 9 zalan 2021-07-07 06:41:08 PDT 
Created attachment 433024 [details]
Patch
Comment 10 Simon Fraser (smfr) 2021-07-07 08:53:08 PDT 
Comment on attachment 433024 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433024&action=review

> Source/WebCore/rendering/LegacyInlineFlowBox.cpp:659
> +        // FIXME: Let's do device pixel snapping at paint time instead.

Can you reference a bugzilla bug in the comment? The "Let's do" makes it hard to judge how important this is; it should be more like "we should not do integral rounding here".

> Source/WebCore/rendering/LegacyInlineFlowBox.cpp:771
>      if (isRootBox) {

Sucks how there's if (isRootBox) logic way up at the start of this function, and here. Would be nice to factor the middle part into separate function.
Comment 11 zalan 2021-07-07 11:19:02 PDT 
Created attachment 433050 [details]
Patch
Comment 12 EWS 2021-07-07 14:35:27 PDT 
Committed r279673 (239480@main): <https://commits.webkit.org/239480@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 433050 [details].