Bug 227593 - WebAudio auto-play policy should come from top document
Summary: WebAudio auto-play policy should come from top document
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on: 227626
Blocks:
  Show dependency tree / graph
 
Reported: 2021-07-01 13:28 PDT by Eric Carlson
Modified: 2021-07-04 09:53 PDT (History)
11 users (show)

See Also:

Attachments
Patch (13.18 KB, patch)
2021-07-01 13:41 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
Patch for landing (13.75 KB, patch)
2021-07-01 15:11 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
Updated patch (13.99 KB, patch)
2021-07-02 14:25 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2021-07-01 13:28:57 PDT 
<audio> and <video> auto-play policy comes from the top document, WebAudio should too.
Comment 1 Eric Carlson 2021-07-01 13:29:16 PDT 
rdar://76920375
Comment 2 Eric Carlson 2021-07-01 13:41:57 PDT 
Created attachment 432720 [details]
Patch
Comment 3 Chris Dumez 2021-07-01 13:51:57 PDT 
Comment on attachment 432720 [details]
Patch

r=me with improvement suggestion
Comment 4 Eric Carlson 2021-07-01 15:11:04 PDT 
Created attachment 432728 [details]
Patch for landing
Comment 5 EWS 2021-07-01 17:08:37 PDT 
Committed r279487 (239339@main): <https://commits.webkit.org/239339@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 432728 [details].
Comment 6 Aakash Jain 2021-07-02 07:43:17 PDT 
(In reply to EWS from comment #5)
> Committed r279487 (239339@main): <https://commits.webkit.org/239339@main>
This added broken test on iOS: media/auto-play-video-in-about-blank-iframe.html 
This was also indicated by ios-wk2 ews (https://ews-build.webkit.org/#/builders/51/builds/16871).

History: https://results.webkit.org/?suite=layout-tests&test=media%2Fauto-play-video-in-about-blank-iframe.html
Comment 7 WebKit Commit Bot 2021-07-02 07:44:17 PDT 
Re-opened since this is blocked by bug 227626
Comment 8 Eric Carlson 2021-07-02 14:25:10 PDT 
Created attachment 432822 [details]
Updated patch
Comment 9 EWS 2021-07-04 09:53:15 PDT 
Committed r279550 (239386@main): <https://commits.webkit.org/239386@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 432822 [details].