Bug 227582 - WebGL video to texture upload spends time clearing the uploaded-to texture
Summary: WebGL video to texture upload spends time clearing the uploaded-to texture
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kimmo Kinnunen
URL:
Keywords: InRadar
Depends on:
Blocks: 227585
  Show dependency tree / graph
 
Reported: 2021-07-01 06:04 PDT by Kimmo Kinnunen
Modified: 2021-07-06 15:34 PDT (History)
7 users (show)

See Also:

Attachments
Patch (8.27 KB, patch)
2021-07-01 08:04 PDT, Kimmo Kinnunen 		kbr: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kimmo Kinnunen 2021-07-01 06:04:24 PDT 
WebGL video to texture upload spends time clearing the uploaded-to texture
Comment 1 Radar WebKit Bug Importer 2021-07-01 06:04:46 PDT 
<rdar://problem/80020335>
Comment 2 Kimmo Kinnunen 2021-07-01 06:40:06 PDT 
Visible for content where big textures (4k, for example) are used.

https://www.youtube.com/watch?v=HKNI658SKJ4
Comment 3 Kimmo Kinnunen 2021-07-01 08:04:13 PDT 
Created attachment 432690 [details]
Patch
Comment 4 Kenneth Russell 2021-07-01 18:25:40 PDT 
Comment on attachment 432690 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=432690&action=review

Very nice investigation and work. r+ with one small comment.

> Source/WebCore/platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm:271
> +        // WebGL requires that all resources are cleared at creation.

Could you add a comment here that performing robust resource initialization in the VideoTextureCopier adds a large amount of overhead?
Comment 5 Dean Jackson 2021-07-06 15:34:16 PDT 
Committed r279624 (239442@main): <https://commits.webkit.org/239442@main>