Bug 227581 - [Model] Restrict IPC calls to ARKit SPI availability and runtime flag
Summary: [Model] Restrict IPC calls to ARKit SPI availability and runtime flag
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-07-01 05:39 PDT by Antoine Quint
Modified: 2021-07-01 12:38 PDT (History)
7 users (show)

See Also:

Attachments
Patch (29.82 KB, patch)
2021-07-01 05:42 PDT, Antoine Quint 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (34.11 KB, patch)
2021-07-01 06:52 PDT, Antoine Quint 		thorton: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2021-07-01 05:39:24 PDT 
[Model] Restrict IPC calls to ARKit SPI availability and runtime flag
Comment 1 Antoine Quint 2021-07-01 05:42:28 PDT 
Created attachment 432682 [details]
Patch
Comment 2 Antoine Quint 2021-07-01 06:52:39 PDT 
Created attachment 432686 [details]
Patch
Comment 3 Tim Horton 2021-07-01 12:31:09 PDT 
Comment on attachment 432686 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=432686&action=review

> Source/WebKit/UIProcess/Cocoa/ModelElementControllerCocoa.mm:59
> +    if (!m_webPageProxy->preferences().modelElementEnabled())
> +        return;

These could be stronger (like MESSAGE_CHECKs, killing the WP if something unexpected is happening), but this is certainly better than nothing.
Comment 4 Antoine Quint 2021-07-01 12:37:27 PDT 
Committed r279477 (239330@main): <https://commits.webkit.org/239330@main>
Comment 5 Radar WebKit Bug Importer 2021-07-01 12:38:19 PDT 
<rdar://problem/80040015>