Bug 227571 – Fix StructuredClone for streams to handle BigInt64Array / BigUint64Array

• Status: RESOLVED
• Resolution: FIXED
• Component: Bindings

[Timothy Gu]

See https://github.com/heycam/webidl/pull/936. A summary of changes are:

- BigInt64Array and BigUint64Array are introduced as keywords of the Web IDL language
- The ArrayBufferView and BufferSource aliases now include BigInt64Array and BigUint64Array as part of the union.

It looks like this may already have been partially implemented, since

    new Blob([new BigInt64Array([0n])]);

appears to work as expected.

Tests: https://github.com/web-platform-tests/wpt/pull/27920

[Radar WebKit Bug Importer]

<rdar://problem/80309572>

[Yusuke Suzuki]

Created attachment 433168 [details]
Patch

[Chris Dumez]

Comment on attachment 433168 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433168&action=review

> Source/WebCore/ChangeLog:3
> +        [WebIDL] Add BigInt64Array and BigUint64Array support to IDL bindings generator

The title is misleading, this seems to only be fixing a bug in the streams implementation?

This does not impact the bindings generator in any way. Streams is not using the IDL binding generator (unfortunately).

> Source/WebCore/Modules/streams/ReadableStreamInternals.js:460
> +                @readableStreamDefaultControllerEnqueue(teeState.branch2.@readableStreamController, shouldClone ? @structuredCloneForFetch(result.value) : result.value);

Why is this called structuredCloneForFetch? Did you mean structuredCloneForStream?

[Yusuke Suzuki]

Comment on attachment 433168 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433168&action=review

Thanks!

>> Source/WebCore/ChangeLog:3
>> +        [WebIDL] Add BigInt64Array and BigUint64Array support to IDL bindings generator
> 
> The title is misleading, this seems to only be fixing a bug in the streams implementation?
> 
> This does not impact the bindings generator in any way. Streams is not using the IDL binding generator (unfortunately).

Changed the title to reflect the patch.

>> Source/WebCore/Modules/streams/ReadableStreamInternals.js:460
>> +                @readableStreamDefaultControllerEnqueue(teeState.branch2.@readableStreamController, shouldClone ? @structuredCloneForFetch(result.value) : result.value);
> 
> Why is this called structuredCloneForFetch? Did you mean structuredCloneForStream?

I used Fetch since the test is included in wpt/fetch, but it is OK to change it to Stream. Changed.

[Yusuke Suzuki]

Committed r279769 (239539@main): <https://commits.webkit.org/239539@main>