Bug 22757 – break out text caret paint as enabled feature

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Cary Clark]

Android draws input text in a separate thread using a java-based text view. Suppress drawing the caret when the feature is disabled and a text field is selected, to reduce the painting and invalidates that Android responds to.

[Cary Clark]

Created attachment 25887 [details]
patch to allow disabling text caret

one of many patches to get local Android changes into webkit

[Darin Adler]

Comment on attachment 25887 [details]
patch to allow disabling text caret

> Index: JavaScriptCore/ChangeLog
> ===================================================================
> --- JavaScriptCore/ChangeLog	(revision 39135)
> +++ JavaScriptCore/ChangeLog	(working copy)
> @@ -1,3 +1,13 @@
> [phone]  Cary Clark  <[e-mail]>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +	Add ENABLE_TEXT_CARET to permit the ANDROID platform
> +	to invalidate and draw the caret in a separate thread.
> +
> +        * wtf/Platform.h:
> +	Default ENABLE_TEXT_CARET to 1.

ChangeLog has tabs in it. This makes it harder to land the patch, because the committer has to change the tabs to spaces. Please don't use tabs in WebKit changes.

Patch otherwise looks fine. r=me

[Cary Clark]

Created attachment 25889 [details]
patch to allow disabling text caret

replace tabs with spaces in ChangeLogs

[Adam Barth]

Will land.

[Adam Barth]

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	JavaScriptCore/ChangeLog
	M	JavaScriptCore/wtf/Platform.h
	M	WebCore/ChangeLog
	M	WebCore/page/Frame.cpp
Committed r39362
	M	JavaScriptCore/wtf/Platform.h
	M	JavaScriptCore/ChangeLog
	M	WebCore/ChangeLog
	M	WebCore/page/Frame.cpp
r39362 = ed04161a85f1c3cffaec802851b6a437af34d68d (trunk)