Bug 227558 - BytecodeGenerator should emit is_null in more places
Summary: BytecodeGenerator should emit is_null in more places
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-06-30 18:07 PDT by Keith Miller
Modified: 2021-07-14 11:46 PDT (History)
7 users (show)

See Also:

Attachments
Patch (1.95 KB, patch)
2021-06-30 18:20 PDT, Keith Miller 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2021-06-30 18:07:55 PDT 
BytecodeGenerator should emit is_null and is_undefined in more places
Comment 1 Keith Miller 2021-06-30 18:20:57 PDT 
Created attachment 432648 [details]
Patch
Comment 2 Yusuke Suzuki 2021-06-30 18:23:50 PDT 
Comment on attachment 432648 [details]
Patch

I think this is intentional: OpEqNull also checks masquerade-as-undefined while strict-eq-jsnull doesn't.
Comment 3 Keith Miller 2021-06-30 18:28:05 PDT 
(In reply to Yusuke Suzuki from comment #2)
> Comment on attachment 432648 [details]
> Patch
> 
> I think this is intentional: OpEqNull also checks masquerade-as-undefined
> while strict-eq-jsnull doesn't.

Ah, I'm surprised we don't have a test for this...
Comment 4 Mark Lam 2021-06-30 21:19:31 PDT 
(In reply to Keith Miller from comment #3)
> (In reply to Yusuke Suzuki from comment #2)
> > Comment on attachment 432648 [details]
> > Patch
> > 
> > I think this is intentional: OpEqNull also checks masquerade-as-undefined
> > while strict-eq-jsnull doesn't.
> 
> Ah, I'm surprised we don't have a test for this...

Do we have one in testapi?
Comment 5 Radar WebKit Bug Importer 2021-07-07 18:08:20 PDT 
<rdar://problem/80298794>