Bug 227556 - PCM: Change import from CryptoKitCBridging to CryptoKitPrivate
Summary: PCM: Change import from CryptoKitCBridging to CryptoKitPrivate
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: John Wilander
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-06-30 16:49 PDT by John Wilander
Modified: 2021-07-01 18:08 PDT (History)
10 users (show)

See Also:

Attachments
Patch (24.88 KB, patch)
2021-06-30 17:00 PDT, John Wilander 		no flags Details | Formatted Diff | Diff
Patch (25.06 KB, patch)
2021-07-01 15:14 PDT, John Wilander 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Wilander 2021-06-30 16:49:24 PDT 
We should change PCM's import from CryptoKitCBridging to CryptoKitPrivate.
Comment 1 Radar WebKit Bug Importer 2021-06-30 16:49:53 PDT 
<rdar://problem/79992592>
Comment 2 John Wilander 2021-06-30 17:00:24 PDT 
Created attachment 432646 [details]
Patch
Comment 3 Alex Christensen 2021-06-30 17:07:44 PDT 
Comment on attachment 432646 [details]
Patch

Rename as suggested by rdar://79923598
Comment 4 Alex Christensen 2021-06-30 17:09:17 PDT 
Comment on attachment 432646 [details]
Patch

Rename as suggested by rdar://79923598
Sure.
Comment 5 John Wilander 2021-06-30 22:55:06 PDT 
win bot issue is unrelated.
Comment 6 John Wilander 2021-06-30 22:55:26 PDT 
Comment on attachment 432646 [details]
Patch

Thanks for the review, Alex!
Comment 7 EWS 2021-06-30 23:32:47 PDT 
Committed r279452 (239308@main): <https://commits.webkit.org/239308@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 432646 [details].
Comment 8 Amir Mark Jr 2021-07-01 10:08:36 PDT 
Reverted r279452 for reason:

Broke MacOS build

Committed r279467 (239323@main): <https://commits.webkit.org/239323@main>
Comment 9 John Wilander 2021-07-01 15:14:53 PDT 
Created attachment 432730 [details]
Patch
Comment 10 John Wilander 2021-07-01 16:15:21 PDT 
Comment on attachment 432730 [details]
Patch

The orange bubbles are due to a known issue with Python command time outs.

Thanks again, Alex.
Comment 11 EWS 2021-07-01 18:08:01 PDT 
Committed r279491 (239343@main): <https://commits.webkit.org/239343@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 432730 [details].