Bug 227553 - [ Mac ] imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/flow-content-0/dialog.html is failing
Summary: [ Mac ] imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Mac (Intel) Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-06-30 16:04 PDT by ayumi_kojima
Modified: 2021-06-30 16:57 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description ayumi_kojima 2021-06-30 16:04:03 PDT 
imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/flow-content-0/dialog.html

Description: It looks like the test started failing since the change in https://trac.webkit.org/changeset/279427/webkit 
it looks like this change made the subtests pass, so we need to rebasline this test

History: https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fhtml%2Frendering%2Fnon-replaced-elements%2Fflow-content-0%2Fdialog.html

--- /Volumes/Data/worker/bigsur-release-tests-wk1/build/layout-test-results/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/flow-content-0/dialog-expected.txt
+++ /Volumes/Data/worker/bigsur-release-tests-wk1/build/layout-test-results/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/flow-content-0/dialog-actual.txt
@@ -3,8 +3,8 @@
 PASS Closed dialog in width: 540px iframe
 PASS Open dialog in width: 540px iframe
-FAIL Modal dialog in width: 540px iframe assert_equals: top expected "56px" but got "0px"
+PASS Modal dialog in width: 540px iframe
 PASS Closed dialog in width: 538px iframe
 PASS Open dialog in width: 538px iframe
-FAIL Modal dialog in width: 538px iframe assert_equals: top expected "56px" but got "0px"
+PASS Modal dialog in width: 538px iframe
Comment 1 Radar WebKit Bug Importer 2021-06-30 16:06:02 PDT 
<rdar://problem/79990602>
Comment 2 Truitt Savell 2021-06-30 16:15:47 PDT 
Updated the test expectations for this test in https://trac.webkit.org/changeset/279440/webkit
Comment 3 Chris Dumez 2021-06-30 16:33:00 PDT 
(In reply to Truitt Savell from comment #2)
> Updated the test expectations for this test in
> https://trac.webkit.org/changeset/279440/webkit

Clearly not a failure but rather the test is now passing. This just needs a new baseline.
Comment 4 Chris Dumez 2021-06-30 16:57:59 PDT 
Oh, that's what Truitt did already. Don't mind me :o)