Bug 227544 - Selecting or dragging images that contain recognizable text is difficult in Mail compose
Summary: Selecting or dragging images that contain recognizable text is difficult in M...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-06-30 14:18 PDT by Wenson Hsieh
Modified: 2021-07-01 13:22 PDT (History)
4 users (show)

See Also:

Attachments
Patch (27.06 KB, patch)
2021-07-01 10:23 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2021-06-30 14:18:43 PDT 
.
Comment 1 Wenson Hsieh 2021-07-01 10:23:04 PDT 
Created attachment 432707 [details]
Patch
Comment 2 Devin Rousso 2021-07-01 11:17:22 PDT 
Comment on attachment 432707 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=432707&action=review

r=me

> Source/WebKit/Shared/ios/InteractionInformationAtPosition.h:66
> +    bool isContentEditable { false };

kinda amazed we didn't already have something for this o_0
Comment 3 Wenson Hsieh 2021-07-01 11:49:20 PDT 
Comment on attachment 432707 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=432707&action=review

Thanks for the review!

>> Source/WebKit/Shared/ios/InteractionInformationAtPosition.h:66
>> +    bool isContentEditable { false };
> 
> kinda amazed we didn't already have something for this o_0

Me too! I think the reason for this is that most things that care about editability are rolled into either FocusedElementInfo or EditorState already, instead of this hit-testing-based mechanism (position information).
Comment 4 Wenson Hsieh 2021-07-01 11:49:33 PDT 
rdar://80037228
Comment 5 EWS 2021-07-01 13:22:16 PDT 
Committed r279479 (239332@main): <https://commits.webkit.org/239332@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 432707 [details].