Bug 227544 – Selecting or dragging images that contain recognizable text is difficult in Mail compose

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Wenson Hsieh]

.

[Wenson Hsieh]

Created attachment 432707 [details]
Patch

[Devin Rousso]

Comment on attachment 432707 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=432707&action=review

r=me

> Source/WebKit/Shared/ios/InteractionInformationAtPosition.h:66
> +    bool isContentEditable { false };

kinda amazed we didn't already have something for this o_0

[Wenson Hsieh]

Comment on attachment 432707 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=432707&action=review

Thanks for the review!

>> Source/WebKit/Shared/ios/InteractionInformationAtPosition.h:66
>> +    bool isContentEditable { false };
> 
> kinda amazed we didn't already have something for this o_0

Me too! I think the reason for this is that most things that care about editability are rolled into either FocusedElementInfo or EditorState already, instead of this hit-testing-based mechanism (position information).

[Wenson Hsieh]

rdar://80037228

[EWS]

Committed r279479 (239332@main): <https://commits.webkit.org/239332@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 432707 [details].