WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
227520
move some Mac MathML test expectation files around again
https://bugs.webkit.org/show_bug.cgi?id=227520
Summary
move some Mac MathML test expectation files around again
Cameron McCormack (:heycam)
Reported
2021-06-29 23:39:00 PDT
Bug 226868
wasn't quite enough to make the same expectation file be used for BigSur+.
Attachments
Patch
(28.48 KB, patch)
2021-06-29 23:48 PDT
,
Cameron McCormack (:heycam)
no flags
Details
Formatted Diff
Diff
Patch
(51.46 KB, patch)
2021-07-04 23:03 PDT
,
Cameron McCormack (:heycam)
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Cameron McCormack (:heycam)
Comment 1
2021-06-29 23:39:49 PDT
<
rdar://79749198
>
Cameron McCormack (:heycam)
Comment 2
2021-06-29 23:48:44 PDT
Created
attachment 432569
[details]
Patch
Cameron McCormack (:heycam)
Comment 3
2021-06-29 23:54:13 PDT
Basically mac-catalina-{wk1,wk2} and mac-mojave-wk1 use one expectation file, and everything else on Mac uses another. For most of the tests here, the "everything else" was already the generic expectations file, but a couple had something else as the generic file, so for those I added new files under platform/mac/ to capture them rather than try to work out what other platforms needed their expectation files moved around to accommodate.
EWS
Comment 4
2021-07-01 14:53:14 PDT
Committed
r279485
(
239337@main
): <
https://commits.webkit.org/239337@main
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 432569
[details]
.
Truitt Savell
Comment 5
2021-07-02 13:13:08 PDT
It looks like the expectation changes in
https://trac.webkit.org/changeset/279485/webkit
broke 7 mathML tests on Big Sur tracking in
https://bugs.webkit.org/show_bug.cgi?id=227520
Truitt Savell
Comment 6
2021-07-02 13:14:02 PDT
(In reply to Truitt Savell from
comment #5
)
> It looks like the expectation changes in >
https://trac.webkit.org/changeset/279485/webkit
> > broke 7 mathML tests on Big Sur > > tracking in
https://bugs.webkit.org/show_bug.cgi?id=227634
Corrected bug URL
Truitt Savell
Comment 7
2021-07-02 13:23:00 PDT
Reverted
r279485
for reason: Broke expectations for 7 mathML test on Big Sur wk1 Committed
r279511
(
239363@main
): <
https://commits.webkit.org/239363@main
>
Cameron McCormack (:heycam)
Comment 8
2021-07-04 23:03:57 PDT
Created
attachment 432870
[details]
Patch
Cameron McCormack (:heycam)
Comment 9
2021-07-04 23:06:53 PDT
(In reply to Truitt Savell from
comment #7
)
> Broke expectations for 7 mathML test on Big Sur wk1
Forgot to remove the platform/mac-wk1/ files in the earlier patch, which caused those failures. Fingers crossed this new patch works everywhere. I've tested locally on {Monterey,BigSur} x {WK2,WK1}. Also just realized we no longer test on Mojave so removed those files.
Cameron McCormack (:heycam)
Comment 10
2021-07-05 13:56:08 PDT
***
Bug 201680
has been marked as a duplicate of this bug. ***
EWS
Comment 11
2021-07-05 13:59:51 PDT
Committed
r279570
(
239401@main
): <
https://commits.webkit.org/239401@main
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 432870
[details]
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug