Bug 227520 - move some Mac MathML test expectation files around again
Summary: move some Mac MathML test expectation files around again
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Cameron McCormack (:heycam)
URL:
Keywords: InRadar
: 201680 (view as bug list)
Depends on:
Blocks:
 
Reported: 2021-06-29 23:39 PDT by Cameron McCormack (:heycam)
Modified: 2021-07-05 13:59 PDT (History)
5 users (show)

See Also:


Attachments
Patch (28.48 KB, patch)
2021-06-29 23:48 PDT, Cameron McCormack (:heycam)
no flags Details | Formatted Diff | Diff
Patch (51.46 KB, patch)
2021-07-04 23:03 PDT, Cameron McCormack (:heycam)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Cameron McCormack (:heycam) 2021-06-29 23:39:00 PDT
Bug 226868 wasn't quite enough to make the same expectation file be used for BigSur+.
Comment 1 Cameron McCormack (:heycam) 2021-06-29 23:39:49 PDT
<rdar://79749198>
Comment 2 Cameron McCormack (:heycam) 2021-06-29 23:48:44 PDT
Created attachment 432569 [details]
Patch
Comment 3 Cameron McCormack (:heycam) 2021-06-29 23:54:13 PDT
Basically mac-catalina-{wk1,wk2} and mac-mojave-wk1 use one expectation file, and everything else on Mac uses another.  For most of the tests here, the "everything else" was already the generic expectations file, but a couple had something else as the generic file, so for those I added new files under platform/mac/ to capture them rather than try to work out what other platforms needed their expectation files moved around to accommodate.
Comment 4 EWS 2021-07-01 14:53:14 PDT
Committed r279485 (239337@main): <https://commits.webkit.org/239337@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 432569 [details].
Comment 5 Truitt Savell 2021-07-02 13:13:08 PDT
It looks like the expectation changes in https://trac.webkit.org/changeset/279485/webkit

broke 7 mathML tests on Big Sur

tracking in https://bugs.webkit.org/show_bug.cgi?id=227520
Comment 6 Truitt Savell 2021-07-02 13:14:02 PDT
(In reply to Truitt Savell from comment #5)
> It looks like the expectation changes in
> https://trac.webkit.org/changeset/279485/webkit
> 
> broke 7 mathML tests on Big Sur
> 
> tracking in https://bugs.webkit.org/show_bug.cgi?id=227634

Corrected bug URL
Comment 7 Truitt Savell 2021-07-02 13:23:00 PDT
Reverted r279485 for reason:

Broke expectations for 7 mathML test on Big Sur wk1

Committed r279511 (239363@main): <https://commits.webkit.org/239363@main>
Comment 8 Cameron McCormack (:heycam) 2021-07-04 23:03:57 PDT
Created attachment 432870 [details]
Patch
Comment 9 Cameron McCormack (:heycam) 2021-07-04 23:06:53 PDT
(In reply to Truitt Savell from comment #7)
> Broke expectations for 7 mathML test on Big Sur wk1

Forgot to remove the platform/mac-wk1/ files in the earlier patch, which caused those failures.

Fingers crossed this new patch works everywhere.  I've tested locally on {Monterey,BigSur} x {WK2,WK1}.  Also just realized we no longer test on Mojave so removed those files.
Comment 10 Cameron McCormack (:heycam) 2021-07-05 13:56:08 PDT
*** Bug 201680 has been marked as a duplicate of this bug. ***
Comment 11 EWS 2021-07-05 13:59:51 PDT
Committed r279570 (239401@main): <https://commits.webkit.org/239401@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 432870 [details].