Bug 227508 - Remove unnecessary canBeInternal invocations to mitigate the cost of potential unmatched patterns in B3LowerToAir
Summary: Remove unnecessary canBeInternal invocations to mitigate the cost of potentia...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yijia Huang
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-06-29 15:10 PDT by Yijia Huang
Modified: 2021-07-01 11:25 PDT (History)
8 users (show)

See Also:


Attachments
Patch (8.93 KB, patch)
2021-07-01 08:54 PDT, Yijia Huang
no flags Details | Formatted Diff | Diff
Patch (8.93 KB, patch)
2021-07-01 09:07 PDT, Yijia Huang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yijia Huang 2021-06-29 15:10:54 PDT
...
Comment 1 Yijia Huang 2021-07-01 08:54:20 PDT
Created attachment 432701 [details]
Patch
Comment 2 Keith Miller 2021-07-01 09:02:55 PDT
Comment on attachment 432701 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=432701&action=review

> Source/JavaScriptCore/ChangeLog:10
> +        The bit pattern doesn't cause the worst code generation in the all-internals-are-captured 
> +        case. So, they don't need canBeInternal checks which might terminate potential matched 
> +        scenarios.

Nit: doesn't cause the worst => doesn't cause worse.
Comment 3 Yijia Huang 2021-07-01 09:07:19 PDT
Created attachment 432703 [details]
Patch
Comment 4 EWS 2021-07-01 11:24:17 PDT
Committed r279473 (239327@main): <https://commits.webkit.org/239327@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 432703 [details].
Comment 5 Radar WebKit Bug Importer 2021-07-01 11:25:31 PDT
<rdar://problem/80035749>