Bug 22748 - Port the op_j?n?eq_null JIT code generation to use the MacroAssembler.
Summary: Port the op_j?n?eq_null JIT code generation to use the MacroAssembler.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Gavin Barraclough
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-12-08 20:22 PST by Gavin Barraclough
Modified: 2008-12-08 20:54 PST (History)
0 users

See Also:


Attachments
The patch (8.10 KB, patch)
2008-12-08 20:30 PST, Gavin Barraclough
oliver: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2008-12-08 20:22:55 PST
Clean up slightly at the same time.  The 'j' forms currently compare, then set a register, then compare again, then branch.  Branch directly on the result of the first compare.
Comment 1 Gavin Barraclough 2008-12-08 20:30:44 PST
Created attachment 25869 [details]
The patch

Around a 1% progression on deltablue, crypto & early boyer, for about 1/2% overall on v8-tests.
Comment 2 Gavin Barraclough 2008-12-08 20:54:23 PST
Sending        JavaScriptCore/ChangeLog
Sending        JavaScriptCore/jit/JIT.cpp
Sending        JavaScriptCore/jit/JITPropertyAccess.cpp
Transmitting file data ...
Committed revision 39122.