Bug 227462 - Nullptr crash in ResourceLoadStatisticsDatabaseStore::allAttributedPrivateClickMeasurement
Summary: Nullptr crash in ResourceLoadStatisticsDatabaseStore::allAttributedPrivateCli...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sihui Liu
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-06-28 14:53 PDT by Sihui Liu
Modified: 2021-06-28 17:21 PDT (History)
2 users (show)

See Also:


Attachments
Patch (2.75 KB, patch)
2021-06-28 14:59 PDT, Sihui Liu
no flags Details | Formatted Diff | Diff
Patch for landing (2.28 KB, patch)
2021-06-28 15:19 PDT, Sihui Liu
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sihui Liu 2021-06-28 14:53:52 PDT
...
Comment 1 Sihui Liu 2021-06-28 14:54:25 PDT
rdar://50772934
Comment 2 Sihui Liu 2021-06-28 14:59:48 PDT
Created attachment 432427 [details]
Patch
Comment 3 Chris Dumez 2021-06-28 15:01:55 PDT
Comment on attachment 432427 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=432427&action=review

> Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp:3509
> +        return attributions;

Darin told me in the past to return { }; in such cases and not move the variable declaration so I am passing along the comment :)
Comment 4 Sihui Liu 2021-06-28 15:19:20 PDT
Created attachment 432430 [details]
Patch for landing
Comment 5 EWS 2021-06-28 17:21:58 PDT
Committed r279353 (239221@main): <https://commits.webkit.org/239221@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 432430 [details].