webkitcorepy.tests.task_pool_unittest.TaskPoolUnittest.test_invalid_shutdown is racey on EWS, because it relies on the parent process terminating it's children before the children have a chance to finish their computation.
<rdar://problem/79873003>
Created attachment 432410 [details] Patch
Failures like this one https://ews-build.webkit.org/#/builders/5/builds/55039/steps/11/logs/stdio are the ones I'm trying to address.
History of this test: https://results.webkit.org/?suite=webkitpy-tests&test=webkitcorepy.tests.task_pool_unittest.TaskPoolUnittest.test_invalid_shutdown
Comment on attachment 432410 [details] Patch r=me, this seems to be a mitigation, but theoretically doesn't fix the race itself.
(In reply to dewei_zhu from comment #5) > Comment on attachment 432410 [details] > Patch > > r=me, this seems to be a mitigation, but theoretically doesn't fix the race > itself. It doesn't fix the race, but it's hard to see how we could (and still retain the test). The test is basically verifying that the parent can and does terminate a child process if it's taking too long to complete. We clearly want some kind of limit on how long the child runs, in case the parent actually isn't terminating the child
Committed r279345 (239213@main): <https://commits.webkit.org/239213@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 432410 [details].
Reopening to attach new patch.
Created attachment 434429 [details] Patch
The original change didn't fix our flakiness. This test isn't super valuable in the first place, I think we should just delete it.
Comment on attachment 434429 [details] Patch How does deleting a function fix a race condition?
Comment on attachment 434429 [details] Patch Oh, I get it, deleting a test (not just a function).
Comment on attachment 434429 [details] Patch r=me
Committed r280412 (240052@main): <https://commits.webkit.org/240052@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 434429 [details].