Bug 227453 – Live Text selections inside images is misaligned when "object-fit" is not "fill"

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Wenson Hsieh]

On a Mac that supports live text:

1. Go to https://whsieh.github.io/examples/live-text
2. Try to select text in the images after the first

[Wenson Hsieh]

Created attachment 432403 [details]
Patch

[Wenson Hsieh]

Created attachment 432414 [details]
Patch

[Tim Horton]

Comment on attachment 432414 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=432414&action=review

> Source/WebCore/html/HTMLElement.cpp:1466
> +    document().updateLayoutIfDimensionsOutOfDate(*this);

I don't think this is the right kind of layout? I think you want the normal update-if-needed-recursively

[Wenson Hsieh]

Comment on attachment 432414 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=432414&action=review

>> Source/WebCore/html/HTMLElement.cpp:1466
>> +    document().updateLayoutIfDimensionsOutOfDate(*this);
> 
> I don't think this is the right kind of layout? I think you want the normal update-if-needed-recursively

Good point — will change this to just be a standard `document().updateLayoutIgnorePendingStylesheets();`.

[Wenson Hsieh]

Created attachment 432419 [details]
Patch for landing

[EWS]

Committed r279349 (239217@main): <https://commits.webkit.org/239217@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 432419 [details].

[Radar WebKit Bug Importer]

<rdar://problem/79882889>