Bug 227451 – ANGLE Metal index buffer restart range cache is could be maintained more consistently

• Status: RESOLVED
• Resolution: FIXED
• Component: ANGLE

[Kimmo Kinnunen]

ANGLE Metal index buffer left mapped when building primitive restart ranges

- When other cache buffers are marked dirty, the cache is cleared. When other cache buffers are detached, the cache is not cleared.
- When buffer is interpreted differently, the cache is not cleared.

[Kimmo Kinnunen]

Created attachment 432477 [details]
Patch

[EWS Watchlist]

Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE

[Kenneth Russell]

Comment on attachment 432477 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=432477&action=review

Looks good to me. r+

> Source/ThirdParty/ANGLE/ChangeLog:3
> +        ANGLE Metal index buffer restart range cache is could be maintained more consistently

"is could" -> "could" (bug description should be updated too)

[Radar WebKit Bug Importer]

<rdar://problem/80177894>

[EWS]

Committed r281550 (240917@main): <https://commits.webkit.org/240917@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 432477 [details].