Bug 227451 - ANGLE Metal index buffer restart range cache is could be maintained more consistently
Summary: ANGLE Metal index buffer restart range cache is could be maintained more cons...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: ANGLE (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kimmo Kinnunen
URL:
Keywords: InRadar
Depends on: 227371
Blocks:
  Show dependency tree / graph
 
Reported: 2021-06-28 08:03 PDT by Kimmo Kinnunen
Modified: 2021-08-25 00:42 PDT (History)
7 users (show)

See Also:

Attachments
Patch (5.19 KB, patch)
2021-06-29 06:55 PDT, Kimmo Kinnunen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kimmo Kinnunen 2021-06-28 08:03:19 PDT 
ANGLE Metal index buffer left mapped when building primitive restart ranges

- When other cache buffers are marked dirty, the cache is cleared. When other cache buffers are detached, the cache is not cleared.
- When buffer is interpreted differently, the cache is not cleared.
Comment 1 Kimmo Kinnunen 2021-06-29 06:55:08 PDT 
Created attachment 432477 [details]
Patch
Comment 2 EWS Watchlist 2021-06-29 06:56:17 PDT 
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Comment 3 Kenneth Russell 2021-06-29 16:03:24 PDT 
Comment on attachment 432477 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=432477&action=review

Looks good to me. r+

> Source/ThirdParty/ANGLE/ChangeLog:3
> +        ANGLE Metal index buffer restart range cache is could be maintained more consistently

"is could" -> "could" (bug description should be updated too)
Comment 4 Radar WebKit Bug Importer 2021-07-05 08:04:16 PDT 
<rdar://problem/80177894>
Comment 5 EWS 2021-08-25 00:42:43 PDT 
Committed r281550 (240917@main): <https://commits.webkit.org/240917@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 432477 [details].