Bug 227444 – Make LocalSampleBufferDisplayLayer::requestNotificationWhenReadyForVideoData hop to main thread before hopping to processing thread

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[youenn fablet]

Make LocalSampleBufferDisplayLayer::requestNotificationWhenReadyForVideoData hop to main thread before hopping to processing thread

[youenn fablet]

<rdar://79413368>

[youenn fablet]

Created attachment 432384 [details]
Patch

[youenn fablet]

ping review

[Chris Dumez]

Comment on attachment 432384 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=432384&action=review

> Source/WebCore/platform/graphics/avfoundation/objc/LocalSampleBufferDisplayLayer.mm:401
> +        m_processingQueue->dispatch([this] {

Why is this safe? What guarantees that |this| is still alive when the lambda runs?

[youenn fablet]

(In reply to Chris Dumez from comment #4)
> Comment on attachment 432384 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=432384&action=review
> 
> > Source/WebCore/platform/graphics/avfoundation/objc/LocalSampleBufferDisplayLayer.mm:401
> > +        m_processingQueue->dispatch([this] {
> 
> Why is this safe? What guarantees that |this| is still alive when the lambda
> runs?

We are doing a dispatchSync in LocalSampleBufferDisplayLayer destructor.

[Chris Dumez]

Comment on attachment 432384 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=432384&action=review

>>> Source/WebCore/platform/graphics/avfoundation/objc/LocalSampleBufferDisplayLayer.mm:401
>>> +        m_processingQueue->dispatch([this] {
>> 
>> Why is this safe? What guarantees that |this| is still alive when the lambda runs?
> 
> We are doing a dispatchSync in LocalSampleBufferDisplayLayer destructor.

Ah, sneaky :) Seems safe indeed then. Sorry about the noise.

[EWS]

Committed r279500 (239352@main): <https://commits.webkit.org/239352@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 432384 [details].