Bug 227439 - RealtimeIncomingAudioSourceCocoa should support other sample rate than 48000
Summary: RealtimeIncomingAudioSourceCocoa should support other sample rate than 48000
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-06-28 02:38 PDT by youenn fablet
Modified: 2021-07-01 03:48 PDT (History)
10 users (show)

See Also:

Attachments
Patch (2.64 KB, patch)
2021-06-28 02:46 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (7.57 KB, patch)
2021-06-28 04:54 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (7.57 KB, patch)
2021-06-28 23:58 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (7.49 KB, patch)
2021-06-30 02:07 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (9.51 KB, patch)
2021-07-01 00:45 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (7.49 KB, patch)
2021-07-01 01:14 PDT, youenn fablet 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2021-06-28 02:38:04 PDT 
Log number of frames and chunks in RealtimeIncomingAudioSourceCocoa
Comment 1 youenn fablet 2021-06-28 02:46:13 PDT 
Created attachment 432376 [details]
Patch
Comment 2 youenn fablet 2021-06-28 04:53:26 PDT 
rdar://79672067
Comment 3 youenn fablet 2021-06-28 04:54:56 PDT 
Created attachment 432382 [details]
Patch
Comment 4 Eric Carlson 2021-06-28 09:19:21 PDT 
Comment on attachment 432382 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=432382&action=review

> Source/WebCore/ChangeLog:8
> +        We reduced memory allocations by early allocating buffers for the most often used sample rate (48000), but this broken other sample rates, like for G722.

s/this broken/this broke/
Comment 5 youenn fablet 2021-06-28 23:58:26 PDT 
Created attachment 432456 [details]
Patch for landing
Comment 6 EWS 2021-06-29 09:56:03 PDT 
Eric Carlsom found in /Volumes/Data/worker/Commit-Queue/build/Source/WebCore/ChangeLog does not appear to be a valid reviewer according to contributors.json.
/Volumes/Data/worker/Commit-Queue/build/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).
Comment 7 youenn fablet 2021-06-30 02:07:36 PDT 
Created attachment 432576 [details]
Patch for landing
Comment 8 youenn fablet 2021-07-01 00:45:35 PDT 
Created attachment 432663 [details]
Patch for landing
Comment 9 youenn fablet 2021-07-01 01:14:25 PDT 
Created attachment 432668 [details]
Patch for landing
Comment 10 EWS 2021-07-01 03:19:31 PDT 
Committed r279459 (239315@main): <https://commits.webkit.org/239315@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 432668 [details].