RESOLVED FIXED 227439
RealtimeIncomingAudioSourceCocoa should support other sample rate than 48000 
https://bugs.webkit.org/show_bug.cgi?id=227439
Summary RealtimeIncomingAudioSourceCocoa should support other sample rate than 48000
youenn fablet
Reported 2021-06-28 02:38:04 PDT
Log number of frames and chunks in RealtimeIncomingAudioSourceCocoa
Attachments
Patch (2.64 KB, patch)
2021-06-28 02:46 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (7.57 KB, patch)
2021-06-28 04:54 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (7.57 KB, patch)
2021-06-28 23:58 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (7.49 KB, patch)
2021-06-30 02:07 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (9.51 KB, patch)
2021-07-01 00:45 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (7.49 KB, patch)
2021-07-01 01:14 PDT, youenn fablet 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2021-06-28 02:46:13 PDT
Created attachment 432376 [details] Patch
youenn fablet
Comment 2 2021-06-28 04:53:26 PDT
rdar://79672067
youenn fablet
Comment 3 2021-06-28 04:54:56 PDT
Created attachment 432382 [details] Patch
Eric Carlson
Comment 4 2021-06-28 09:19:21 PDT
Comment on attachment 432382 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=432382&action=review > Source/WebCore/ChangeLog:8 > + We reduced memory allocations by early allocating buffers for the most often used sample rate (48000), but this broken other sample rates, like for G722. s/this broken/this broke/
youenn fablet
Comment 5 2021-06-28 23:58:26 PDT
Created attachment 432456 [details] Patch for landing
EWS
Comment 6 2021-06-29 09:56:03 PDT
Eric Carlsom found in /Volumes/Data/worker/Commit-Queue/build/Source/WebCore/ChangeLog does not appear to be a valid reviewer according to contributors.json. /Volumes/Data/worker/Commit-Queue/build/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).
youenn fablet
Comment 7 2021-06-30 02:07:36 PDT
Created attachment 432576 [details] Patch for landing
youenn fablet
Comment 8 2021-07-01 00:45:35 PDT
Created attachment 432663 [details] Patch for landing
youenn fablet
Comment 9 2021-07-01 01:14:25 PDT
Created attachment 432668 [details] Patch for landing
EWS
Comment 10 2021-07-01 03:19:31 PDT
Committed r279459 (239315@main): <https://commits.webkit.org/239315@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 432668 [details].
Note You need to log in before you can comment on or make changes to this bug.