Bug 227414 - I-beam pointer is vertical for vertical text
Summary: I-beam pointer is vertical for vertical text
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kate Cheney
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-06-25 17:19 PDT by Kate Cheney
Modified: 2021-06-28 16:52 PDT (History)
3 users (show)

See Also:

Attachments
Patch (7.05 KB, patch)
2021-06-25 17:28 PDT, Kate Cheney 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kate Cheney 2021-06-25 17:19:58 PDT 
The iBeam should be horizontal for vertical text EPUBs
Comment 1 Kate Cheney 2021-06-25 17:20:13 PDT 
rdar://77564647
Comment 2 Kate Cheney 2021-06-25 17:28:53 PDT 
Created attachment 432315 [details]
Patch
Comment 3 Tim Horton 2021-06-28 10:12:50 PDT 
Comment on attachment 432315 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=432315&action=review

> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:3038
>      info.lineCaretExtent = view->contentsToRootView(lineRect);

Does this rectangle maybe need adjusting as well? The fact that we explicitly set lineRect's width but never height seems ... fishy.
Comment 4 Kate Cheney 2021-06-28 16:17:10 PDT 
(In reply to Tim Horton from comment #3)
> Comment on attachment 432315 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=432315&action=review
> 
> > Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:3038
> >      info.lineCaretExtent = view->contentsToRootView(lineRect);
> 
> Does this rectangle maybe need adjusting as well? The fact that we
> explicitly set lineRect's width but never height seems ... fishy.

I filed rdar://77564647, Alan offered to investigate the misaligned region returned in pointerRegionForPositionInformation. Maybe we can land this piece now, though.
Comment 5 Kate Cheney 2021-06-28 16:18:01 PDT 
(In reply to Kate Cheney from comment #4)
> (In reply to Tim Horton from comment #3)
> > Comment on attachment 432315 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=432315&action=review
> > 
> > > Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:3038
> > >      info.lineCaretExtent = view->contentsToRootView(lineRect);
> > 
> > Does this rectangle maybe need adjusting as well? The fact that we
> > explicitly set lineRect's width but never height seems ... fishy.
> 
> I filed rdar://77564647, Alan offered to investigate the misaligned region
> returned in pointerRegionForPositionInformation. Maybe we can land this
> piece now, though.

Edit: I filed rdar://79887141.
Comment 6 Tim Horton 2021-06-28 16:21:32 PDT 
Comment on attachment 432315 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=432315&action=review

>>>> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:3038
>>>>      info.lineCaretExtent = view->contentsToRootView(lineRect);
>>> 
>>> Does this rectangle maybe need adjusting as well? The fact that we explicitly set lineRect's width but never height seems ... fishy.
>> 
>> I filed rdar://77564647, Alan offered to investigate the misaligned region returned in pointerRegionForPositionInformation. Maybe we can land this piece now, though.
> 
> Edit: I filed rdar://79887141.

Yeah, as long as this doesn't make it any worse, I'm on board.
Comment 7 EWS 2021-06-28 16:52:35 PDT 
Committed r279351 (239219@main): <https://commits.webkit.org/239219@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 432315 [details].