Bug 227414 – I-beam pointer is vertical for vertical text

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit API

[Kate Cheney]

The iBeam should be horizontal for vertical text EPUBs

[Kate Cheney]

rdar://77564647

[Kate Cheney]

Created attachment 432315 [details]
Patch

[Tim Horton]

Comment on attachment 432315 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=432315&action=review

> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:3038
>      info.lineCaretExtent = view->contentsToRootView(lineRect);

Does this rectangle maybe need adjusting as well? The fact that we explicitly set lineRect's width but never height seems ... fishy.

[Kate Cheney]

(In reply to Tim Horton from comment #3)
> Comment on attachment 432315 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=432315&action=review
> 
> > Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:3038
> >      info.lineCaretExtent = view->contentsToRootView(lineRect);
> 
> Does this rectangle maybe need adjusting as well? The fact that we
> explicitly set lineRect's width but never height seems ... fishy.

I filed rdar://77564647, Alan offered to investigate the misaligned region returned in pointerRegionForPositionInformation. Maybe we can land this piece now, though.

[Kate Cheney]

(In reply to Kate Cheney from comment #4)
> (In reply to Tim Horton from comment #3)
> > Comment on attachment 432315 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=432315&action=review
> > 
> > > Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:3038
> > >      info.lineCaretExtent = view->contentsToRootView(lineRect);
> > 
> > Does this rectangle maybe need adjusting as well? The fact that we
> > explicitly set lineRect's width but never height seems ... fishy.
> 
> I filed rdar://77564647, Alan offered to investigate the misaligned region
> returned in pointerRegionForPositionInformation. Maybe we can land this
> piece now, though.

Edit: I filed rdar://79887141.

[Tim Horton]

Comment on attachment 432315 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=432315&action=review

>>>> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:3038
>>>>      info.lineCaretExtent = view->contentsToRootView(lineRect);
>>> 
>>> Does this rectangle maybe need adjusting as well? The fact that we explicitly set lineRect's width but never height seems ... fishy.
>> 
>> I filed rdar://77564647, Alan offered to investigate the misaligned region returned in pointerRegionForPositionInformation. Maybe we can land this piece now, though.
> 
> Edit: I filed rdar://79887141.

Yeah, as long as this doesn't make it any worse, I'm on board.

[EWS]

Committed r279351 (239219@main): <https://commits.webkit.org/239219@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 432315 [details].