Bug 227403 – [GStreamer][EME] Fix resources release when a MediaKeySession is closed

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Xabier Rodríguez Calvar]

[GStreamer][EME] Fix resources release when a MediaKeySession is closed

[Xabier Rodríguez Calvar]

Created attachment 432273 [details]
Patch

[Philippe Normand]

Comment on attachment 432273 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=432273&action=review

> Source/WebCore/platform/graphics/gstreamer/eme/CDMThunder.cpp:589
> -    if (!m_session || m_sessionID.isEmpty() || opencdm_session_update(m_session.get(), response->data(), response->size()))
> +    if (!m_session || m_sessionID.isEmpty() || opencdm_session_update(m_session->get(), response->dataAsUInt8Ptr(), response->size()))

dataAsUInt8Ptr does not exist anymore. Please revert this part.

[Xabier Rodríguez Calvar]

Created attachment 432277 [details]
Patch

[Philippe Normand]

Comment on attachment 432277 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=432277&action=review

> Source/WebCore/ChangeLog:21
> +        are only needed in the CDMProxy class, which is there they are

s/there/where?

> Source/WebCore/ChangeLog:28
> +        shared among different sessions. We were managing session
> +        references in other stores and they were messing up with the
> +        session in the CDMProxy class, that prevented sessions from
> +        staying when there are other MediaKeySessions referencing the same
> +        key IDs and from being removed then a session was closed and there
> +        was only that reference in the CDMProxy (because they could be
> +        held by the other stores, where references are unnecessary.

This sentence is 7 lines long :) I had some trouble to parse it too.

> Source/WebCore/platform/encryptedmedia/CDMProxy.cpp:186
> +void KeyStore::removeAllKeys()

clear() maybe?

[Xabier Rodríguez Calvar]

Created attachment 432396 [details]
Patch

[EWS]

Committed r279363 (239229@main): <https://commits.webkit.org/239229@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 432396 [details].

[Radar WebKit Bug Importer]

<rdar://problem/79899771>