Bug 227395 - [css-flexbox] Improve computation of intrinsic sizes of flex items with aspect ratio
Summary: [css-flexbox] Improve computation of intrinsic sizes of flex items with aspec...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sergio Villar Senin
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-06-25 04:26 PDT by Sergio Villar Senin
Modified: 2021-06-25 08:43 PDT (History)
12 users (show)

See Also:


Attachments
Patch (9.56 KB, patch)
2021-06-25 07:18 PDT, Sergio Villar Senin
rbuis: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sergio Villar Senin 2021-06-25 04:26:35 PDT
[css-flexbox] Improve computation of intrinsic sizes of flex items with aspect ratio
Comment 1 Sergio Villar Senin 2021-06-25 07:18:10 PDT
Created attachment 432267 [details]
Patch
Comment 2 Rob Buis 2021-06-25 07:40:47 PDT
Comment on attachment 432267 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=432267&action=review

> Source/WebCore/ChangeLog:12
> +        sizes mentioned in the specs https://drafts.csswg.org/css-flexbox/#definite-sizes.

Would do "in the specs, see http:....", "in the specs (http:....)" or make a footnote [1].
Comment 3 Sergio Villar Senin 2021-06-25 08:42:18 PDT
Committed r279286 (239165@main): <https://commits.webkit.org/239165@main>
Comment 4 Radar WebKit Bug Importer 2021-06-25 08:43:16 PDT
<rdar://problem/79779996>