Bug 227386 - Fix null crash in AudioMediaStreamTrackRendererCocoa::start
Summary: Fix null crash in AudioMediaStreamTrackRendererCocoa::start
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-06-24 23:33 PDT by Alex Christensen
Modified: 2021-06-25 12:51 PDT (History)
10 users (show)

See Also:

Attachments
Patch (2.00 KB, patch)
2021-06-24 23:37 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2021-06-24 23:33:11 PDT 
Fix null crash in AudioMediaStreamTrackRendererCocoa::start
Comment 1 Alex Christensen 2021-06-24 23:37:13 PDT 
Created attachment 432240 [details]
Patch
Comment 2 Alex Christensen 2021-06-24 23:37:16 PDT 
<rdar://problem/79045120>
Comment 3 youenn fablet 2021-06-25 05:06:48 PDT 
Comment on attachment 432240 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=432240&action=review

> Source/WebCore/ChangeLog:11
> +        has an early return or hasn't been called yet.

It probably means we have an early return, which means we have an error case when creating the audio unit.
Release logging would tell us what actually happened.
Comment 4 Alex Christensen 2021-06-25 12:41:36 PDT 
Comment on attachment 432240 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=432240&action=review

>> Source/WebCore/ChangeLog:11
>> +        has an early return or hasn't been called yet.
> 
> It probably means we have an early return, which means we have an error case when creating the audio unit.
> Release logging would tell us what actually happened.

There's already release logging in LocalAudioMediaStreamTrackRendererInternalUnit::retrieveFormatDescription
Comment 5 EWS 2021-06-25 12:51:42 PDT 
Committed r279296 (239172@main): <https://commits.webkit.org/239172@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 432240 [details].