We continue to experience some hangs when using AppSSO to authenticate users. This patch adds copious logging to understand the flows through this code, and adds clean-up code in more places to ensure that the modal sheet used by AppSSO is dismissed in cases where the authentication has completed (or failed).
Created attachment 432290 [details] Patch
Comment on attachment 432290 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=432290&action=review > Source/WebKit/UIProcess/Cocoa/SOAuthorization/SOAuthorizationSession.mm:153 > + AUTHORIZATIONSESSION_RELEASE_LOG("shouldStart: m_page=%p", m_page.get()); If m_page is a weakPtr, could that cause issues trying to log if it is destroyed? > Source/WebKit/UIProcess/Cocoa/SOAuthorization/SOAuthorizationSession.mm:172 > + WTFLogAlways("SOAuthorizationSession::start (getAuthorizationHintsWithURL completion handler): Returning early because weakThis is now null."); Why WTFLogAlways instead of AUTHORIZATIONSESSION_RELEASE_LOG?
Created attachment 432297 [details] Patch
Comment on attachment 432297 [details] Patch r=me
Committed r279305 (239181@main): <https://commits.webkit.org/239181@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 432297 [details].
<rdar://problem/79805243>
It looks like the assert added in https://trac.webkit.org/changeset/279305/webkit caused 4 API test crashes. Tracking in: https://bugs.webkit.org/show_bug.cgi?id=227454