Bug 227362 - [GStreamer] TextCombiner has unlinked internal encoders
Summary: [GStreamer] TextCombiner has unlinked internal encoders
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Philippe Normand
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-06-24 10:33 PDT by Philippe Normand
Modified: 2021-06-25 08:40 PDT (History)
7 users (show)

See Also:

Attachments
pipeline dump (178.86 KB, image/svg+xml)
2021-06-24 10:33 PDT, Philippe Normand 		no flags Details
Patch (5.74 KB, patch)
2021-06-24 10:56 PDT, Philippe Normand 		calvaris: review+
calvaris: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2021-06-24 10:33:23 PDT 
Created attachment 432187 [details]
pipeline dump

Oddly this doesn't seem to introduce test failures, unless playbin3 is enabled.

In some tests such as media/track/in-band/track-in-band-kate-ogg-cues-added-once.html the combiner pads can receive multiple caps events describing the same stream, that's not good because then new vtt encoders are added to the combiner and remain unlinked. See attached pipeline dump.
Comment 1 Philippe Normand 2021-06-24 10:56:07 PDT 
Created attachment 432191 [details]
Patch
Comment 2 Xabier Rodríguez Calvar 2021-06-25 07:16:46 PDT 
Comment on attachment 432191 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=432191&action=review

> Source/WebCore/platform/graphics/gstreamer/TextCombinerPadGStreamer.cpp:39
> +    bool processStickyEvents { true };

shouldProcessStickyEvents
Comment 3 Philippe Normand 2021-06-25 08:39:34 PDT 
Committed r279285 (239164@main): <https://commits.webkit.org/239164@main>
Comment 4 Radar WebKit Bug Importer 2021-06-25 08:40:19 PDT 
<rdar://problem/79779869>