Bug 227348 - [GStreamer] Build warnings in AudioFileReader since r279123
Summary: [GStreamer] Build warnings in AudioFileReader since r279123
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Philippe Normand
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-06-24 04:49 PDT by Philippe Normand
Modified: 2021-06-25 08:13 PDT (History)
9 users (show)

See Also:

Attachments
Patch (2.13 KB, patch)
2021-06-24 04:51 PDT, Philippe Normand 		no flags Details | Formatted Diff | Diff
Patch (2.59 KB, patch)
2021-06-24 04:55 PDT, Philippe Normand 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2021-06-24 04:49:17 PDT 
[2156/3527] Building CXX object Source/WebCore/CMakeFiles/WebCore.dir/platform/audio/gstreamer/AudioFileReaderGStreamer.cpp.o
../../Source/WebCore/platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:351:9: warning: variable 'source' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
    if (m_data) {
        ^~~~~~
../../Source/WebCore/platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:361:131: note: uninitialized use occurs here
    gst_bin_add_many(((((GstBin*) g_type_check_instance_cast ((GTypeInstance*) ((m_pipeline.get())), ((gst_bin_get_type ())))))), source, m_decodebin.get(), nullptr);
                                                                                                                                  ^~~~~~
../../Source/WebCore/platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:351:5: note: remove the 'if' if its condition is always true
    if (m_data) {
    ^~~~~~~~~~~~
../../Source/WebCore/platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:350:23: note: initialize the variable 'source' to silence this warning
    GstElement* source;
                      ^
                       = nullptr
1 warning generated.
Comment 1 Philippe Normand 2021-06-24 04:51:41 PDT 
Created attachment 432150 [details]
Patch
Comment 2 Philippe Normand 2021-06-24 04:55:29 PDT 
Created attachment 432151 [details]
Patch
Comment 3 EWS 2021-06-25 08:12:36 PDT 
Committed r279283 (239162@main): <https://commits.webkit.org/239162@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 432151 [details].
Comment 4 Radar WebKit Bug Importer 2021-06-25 08:13:18 PDT 
<rdar://problem/79778888>