Bug 227348 – [GStreamer] Build warnings in AudioFileReader since r279123

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Philippe Normand]

[2156/3527] Building CXX object Source/WebCore/CMakeFiles/WebCore.dir/platform/audio/gstreamer/AudioFileReaderGStreamer.cpp.o
../../Source/WebCore/platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:351:9: warning: variable 'source' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
    if (m_data) {
        ^~~~~~
../../Source/WebCore/platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:361:131: note: uninitialized use occurs here
    gst_bin_add_many(((((GstBin*) g_type_check_instance_cast ((GTypeInstance*) ((m_pipeline.get())), ((gst_bin_get_type ())))))), source, m_decodebin.get(), nullptr);
                                                                                                                                  ^~~~~~
../../Source/WebCore/platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:351:5: note: remove the 'if' if its condition is always true
    if (m_data) {
    ^~~~~~~~~~~~
../../Source/WebCore/platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:350:23: note: initialize the variable 'source' to silence this warning
    GstElement* source;
                      ^
                       = nullptr
1 warning generated.

[Philippe Normand]

Created attachment 432150 [details]
Patch

[Philippe Normand]

Created attachment 432151 [details]
Patch

[EWS]

Committed r279283 (239162@main): <https://commits.webkit.org/239162@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 432151 [details].

[Radar WebKit Bug Importer]

<rdar://problem/79778888>