.
Created attachment 432143 [details] Patch
Comment on attachment 432143 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=432143&action=review > Tools/MiniBrowser/gtk/main.c:149 > + { "enable-sandbox", 0, 0, G_OPTION_ARG_NONE, &enableSandbox, "Enable web process sandbox support", NULL }, Ideally it would be on by default, to have the best chance of avoiding mistakes like developing new features that are incompatible with the sandbox (it has happened recently). I guess the sandbox will probably break layout tests if we're not careful, though. And I know you want to avoid waiting for D-Bus registration when running layout tests. So I would flip it to disable-sandbox, if possible. > Tools/MiniBrowser/gtk/main.c:682 > + if (!webkit_website_data_manager_is_ephemeral(manager)) { > + webkit_web_context_add_path_to_sandbox(webContext, webkit_website_data_manager_get_base_data_directory(manager), TRUE); > + webkit_web_context_add_path_to_sandbox(webContext, webkit_website_data_manager_get_base_cache_directory(manager), TRUE); > + } Um, I thought this was supposed to be done automatically, but I can't find any code for it, so I guess it has to be manual. :/
(In reply to Michael Catanzaro from comment #2) > So I would flip it to disable-sandbox, if possible. If you do this, then we can also close bug #213174. > > Tools/MiniBrowser/gtk/main.c:682 > > + if (!webkit_website_data_manager_is_ephemeral(manager)) { > > + webkit_web_context_add_path_to_sandbox(webContext, webkit_website_data_manager_get_base_data_directory(manager), TRUE); > > + webkit_web_context_add_path_to_sandbox(webContext, webkit_website_data_manager_get_base_cache_directory(manager), TRUE); > > + } > > Um, I thought this was supposed to be done automatically, but I can't find > any code for it, so I guess it has to be manual. :/ Discussing this with Patrick, we think these should not be needed. Does something break if you don't add them? It might be a bug.
Committed r279337 (239205@main): <https://commits.webkit.org/239205@main>