Bug 227338 - Two VideoToolboxSoftLink.h
Summary: Two VideoToolboxSoftLink.h
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jean-Yves Avenard [:jya]
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-06-23 22:21 PDT by Jean-Yves Avenard [:jya]
Modified: 2021-06-23 22:22 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jean-Yves Avenard [:jya] 2021-06-23 22:21:47 PDT 
There's currently two VideoToolboxSoftLink.h

One in WebCore/PAL/pal/cf/VideoToolboxSoftLink.h
the other in WebCore/platform/cocoa/VideoToolboxSoftLink.h

Both soft-link the VideoToolbox framework, but with different methods.
cf/VideoToolboxSoftLink.h mostly targets video encoder
while cocoa/VideoToolboxSoftLink.h targes video decoding session.

Method in the first are added in the PAL namespace while the latter use WebCore.

Sometimes both are used at the same time.

This is confusing, we should merge them, and for consistency have all soft links made under PAL namespace.
Comment 1 Radar WebKit Bug Importer 2021-06-23 22:22:07 PDT 
<rdar://problem/79709759>